{{ message }}
Fix: Throw IllegalArgumentException for null IDs/Src/Dst in toGraphX (Fixes #765)#766
Merged
SemyonSinchenko merged 6 commits intographframes:mainfrom Jan 3, 2026
Merged
Conversation
Collaborator
Collaborator
|
We have both scalafmt and scalafix. If you do not want to use pre-commit, just call |
Contributor
Author
|
Hi @SemyonSinchenko, My bad, I ran the comment and I didn't noticed the error after formatting was done, scalafix and scalafmt passed, I have rebuilt the PR, could you check ? |
Contributor
Author
|
updated the logic, verified test cases and precommit checks locally, could you check ? ;( |
| } | ||
|
|
||
| // 2. Null Src/Dst | ||
| val badEdges = edges.filter(col(SRC).isNull || col(DST).isNull).limit(1).count() |
Collaborator
There was a problem hiding this comment.
Tbh, I do not like it. It is an expensive operation. I would prefer just to raise an exception instead. If no match: an exception that graph is malformed.
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback, I have rebuilt the PR, could you check ?
SemyonSinchenko
approved these changes
Jan 3, 2026
Collaborator
SemyonSinchenko
left a comment
SemyonSinchenko
left a comment
There was a problem hiding this comment.
@JeganVG Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(for #765)
What changes were proposed in this pull request?
Added Two TCs :
Why are the changes needed?
Fixes #765
Currently, if a GraphFrame contains null values in the ID (or src/dst) columns and toGraphX is called, the pattern matching falls, throwing a GraphFramesUnreachableException without proper exception.