feat: add Rocha–Thatte cycle detection algorithm by SemyonSinchenko · Pull Request #700 · graphframes/graphframes · GitHub
Skip to content

feat: add Rocha–Thatte cycle detection algorithm#700

Merged
SemyonSinchenko merged 6 commits intographframes:masterfrom
SemyonSinchenko:607-cycles-detection
Sep 22, 2025
Merged

feat: add Rocha–Thatte cycle detection algorithm#700
SemyonSinchenko merged 6 commits intographframes:masterfrom
SemyonSinchenko:607-cycles-detection

Conversation

@SemyonSinchenko
Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

An implementation of the Rocha–Thatte cycle detection algorithm

Why are the changes needed?

Close #697

@codecov-commenter
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@rjurney rjurney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Python docs

Comment thread docs/src/04-user-guide/05-traversals.md
@SemyonSinchenko
Copy link
Copy Markdown
Collaborator Author

Copy link
Copy Markdown
Collaborator

@rjurney rjurney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Python implementation and docs will follow core.

…ection

# Conflicts:
#	core/src/main/scala/org/graphframes/GraphFrame.scala
+ fix docs generation
Copy link
Copy Markdown
Collaborator

@rjurney rjurney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

+ remove unnecessary distinct
@SemyonSinchenko SemyonSinchenko merged commit 7281d09 into graphframes:master Sep 22, 2025
5 checks passed
@SemyonSinchenko SemyonSinchenko deleted the 607-cycles-detection branch September 22, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Rocha–Thatte cycle detection algorithm

3 participants