{{ message }}
fix(custom-guides): finalize decode warning budget - #1738
Merged
moxious merged 1 commit intoAug 29, 2026
Conversation
BLCCoreStudio
marked this pull request as ready for review
August 29, 2026 19:43
BLCCoreStudio
requested review from
Jayclifford345,
leslie-heinzen and
tomglenn
as code owners
August 29, 2026 19:43
moxious
approved these changes
Aug 29, 2026
moxious
left a comment
moxious
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for making the decode-warning suppression summary run on every catalogue-drain exit and for covering both entry-budget and page-error paths.
No blocking issues. This PR is mergeable.
PR Review: #1738
Summary: finalize decode warning budget
Verdict: Approve
Results: 0 blockers, 0 non-blocking findings, 0 follow-ups
Next: after this approval is published, a maintainer can merge the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The decode-warning suppression summary was previously emitted from
ListPage, which meant it only appeared when pagination reached the final page.A catalogue drain can also stop early when it reaches the aggregate entry budget, or return because a later page fails. In those cases the drain had already accumulated suppressed decode warnings, but the summary was never emitted.
Move that finalization to
drainCustomGuidesso the summary runs once whenever the drain finishes, regardless of which terminal path is taken.Add regression coverage for normal pagination, aggregate-budget truncation, and page errors using the real
customGuideHTTPClient.How to verify
env GOTOOLCHAIN=go1.26.5 go test ./pkg/plugin -count=1env GOTOOLCHAIN=go1.26.5 npm run lint:goenv GOTOOLCHAIN=go1.26.5 npm run test:goLC_ALL=C env GOTOOLCHAIN=go1.26.5 npm run checkBreaking changes
None.
Fixes #1725