{{ message }}
test(go): stabilize RawMessage contract type on Go 1.27 - #1737
Merged
moxious merged 1 commit intoAug 29, 2026
Conversation
BLCCoreStudio
marked this pull request as ready for review
August 29, 2026 19:43
BLCCoreStudio
requested review from
Jayclifford345,
leslie-heinzen and
tomglenn
as code owners
August 29, 2026 19:43
moxious
approved these changes
Aug 29, 2026
moxious
left a comment
moxious
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for stabilizing the RawMessage contract descriptor across Go toolchains — this keeps the repository’s contract golden reliable as Go 1.27 lands.
No blocking issues. This PR is mergeable.
PR Review: #1737
Summary: stabilize RawMessage contract type on Go 1.27
Verdict: Approve
Results: 0 blockers, 0 non-blocking findings, 0 follow-ups
Once this approval is published, a maintainer can take the normal merge decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Go 1.27 reflects
json.RawMessageasjsontext.Value, which makes the contract golden test fail.Handle
json.RawMessagebefore the generic named-type case. Added cases forjson.RawMessageand[]json.RawMessageto keep the descriptor consistent on Go 1.26.5 and Go 1.27.How to verify
Breaking changes
None.
Fixes #1724