{{ message }}
Subgroups proposal: Consider subgroup_size used in compute stage uniform#4652
Merged
Merged
Conversation
subgroup_size built-in variable should be considered uniform for uniformity analysis when used in compute stage uniform.
Contributor
alan-baker
approved these changes
May 23, 2024
alan-baker
left a comment
Contributor
There was a problem hiding this comment.
This makes sense to me.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Currently only
workgroup_idandnum_workgroupsbuilt-in values are considered uniform according to spec.Treating
subgroup_sizeas uniform may help writing flexible kernel that fit to different actual subgroup size, and allow using functions likeworkgroupBarrierandsubgroupBroadcast(if requiring that the subgroup operations only be used in uniform control flow) under condition of subgroup size, likeThe Vulkan spec, in
SubgroupSizeof 15.9. Built-In Variables section, required thatI don't find explicit requirement in MSL/HLSL spec, but I think they should work in the same way for compute kernel.