{{ message }}
chore: Migrate github.com/jinzhu/gorm to gorm.io/gorm - #863
Merged
Conversation
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
This reverts commit b494a3b. Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
jmattheis
reviewed
Oct 17, 2025
jmattheis
left a comment
jmattheis
left a comment
Member
There was a problem hiding this comment.
Code looks good. I'll try to test this with all supported databases on sunday, or next week.
jmattheis
reviewed
Oct 19, 2025
jmattheis
reviewed
Oct 19, 2025
jmattheis
reviewed
Oct 19, 2025
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Member
Author
jmattheis
requested changes
Oct 25, 2025
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
jmattheis
reviewed
Oct 26, 2025
jmattheis
left a comment
jmattheis
left a comment
Member
There was a problem hiding this comment.
postgres and sqlite looks good, but mysql/mariadb has some problems.
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
jmattheis
approved these changes
Oct 29, 2025
jmattheis
left a comment
jmattheis
left a comment
Member
There was a problem hiding this comment.
, please squash the commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #862 .
I removed the manual column fixup: The default column type is already bloba and longblob (I tested on the docker container for MariaDB and postgres).
I also dropped a test that is basically if the database returns error then the function has to return an error, feels a little mechanical coverage driven test not really useful.