Delete an application's image by xavier-GitHub76 · Pull Request #855 · gotify/server · GitHub
Skip to content

Delete an application's image - #855

Merged
jmattheis merged 2 commits into
gotify:masterfrom
xavier-GitHub76:remove-image
Oct 8, 2025
Merged

Delete an application's image#855
jmattheis merged 2 commits into
gotify:masterfrom
xavier-GitHub76:remove-image

Conversation

@xavier-GitHub76

Copy link
Copy Markdown
Contributor

I add a delete button (appearing when the mouse hovers over image)
After confirmation, the delete is done (the API 'DELETE /:id/image' is used) and a snack notification is created

@xavier-GitHub76
xavier-GitHub76 requested a review from a team as a code owner October 6, 2025 19:57
@xavier-GitHub76

Copy link
Copy Markdown
Contributor Author

Comment thread ui/src/application/Applications.tsx Outdated
image,
fEdit,
}: IRowProps) => {
const [isHovered, setIsHovered] = useState(false);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed this to handle the hover effect purely with css and the image always has the onclick handler to delete the image. This make this simpler IMO.

@codecov

codecov Bot commented Oct 8, 2025

Copy link
Copy Markdown

@jmattheis
jmattheis merged commit 9703021 into gotify:master Oct 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants