feat: add the ability to filter place reviews by newest. by nnolan · Pull Request #468 · googlemaps/google-maps-services-python · GitHub
Skip to content

feat: add the ability to filter place reviews by newest.#468

Merged
wangela merged 4 commits into
googlemaps:masterfrom
nnolan:master
Jan 24, 2023
Merged

feat: add the ability to filter place reviews by newest.#468
wangela merged 4 commits into
googlemaps:masterfrom
nnolan:master

Conversation

@nnolan

@nnolan nnolan commented Jan 7, 2023

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #467 🦕

@nnolan nnolan changed the title Add the ability to filter place reviews by newest. feat: add the ability to filter place reviews by newest. Jan 7, 2023
@nnolan

nnolan commented Jan 20, 2023

Copy link
Copy Markdown
Contributor Author

@wangela wangela self-requested a review January 24, 2023 08:26
wangela
wangela requested changes Jan 24, 2023
View reviewed changes

@wangela wangela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!

This repo tries to follow the API as closely as possible. Here are two adjustments to make before I can approve:

  • Throughout, replace review_sort_newest with reviews_sort and copy the parameter description from reviews_sort
  • In places.py L427, the type should be string and in L458, the param should be set to the value of the input argument.

@nnolan

nnolan commented Jan 24, 2023

Copy link
Copy Markdown
Contributor Author

Thank you for your pull request!

This repo tries to follow the API as closely as possible. Here are two adjustments to make before I can approve:

  • Throughout, replace review_sort_newest with reviews_sort and copy the parameter description from reviews_sort
  • In places.py L427, the type should be string and in L458, the param should be set to the value of the input argument.

Thank you for the feedback! I've made the requested changes, please let me know if there is anything else you would like to see changed.

wangela
wangela requested changes Jan 24, 2023
View reviewed changes

@wangela wangela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for incorporating the prior feedback! Just a couple more things. Please make sure the tests pass.

Comment thread googlemaps/places.py Outdated
Comment thread tests/test_places.py Outdated
@nnolan

nnolan commented Jan 24, 2023

Copy link
Copy Markdown
Contributor Author

Thank you for incorporating the prior feedback! Just a couple more things. Please make sure the tests pass.

Thanks again, good callouts. I have made the requested updates, ensured tests pass locally.

@nnolan nnolan requested a review from wangela January 24, 2023 21:10
@wangela wangela merged commit 8afe628 into googlemaps:master Jan 24, 2023
googlemaps-bot pushed a commit that referenced this pull request Jan 24, 2023
@semantic-release-bot
chore(release): 4.9.0 [skip ci]
72c482c 
# [4.9.0](v4.8.0...v4.9.0) (2023-01-24)

### Features

* add support for sorting reviews in Place Details requests ([#468](#468)) ([8afe628](8afe628))
@googlemaps-bot

googlemaps-bot commented Jan 24, 2023

Copy link
Copy Markdown
Contributor

@wangela wangela mentioned this pull request Jan 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangela wangela wangela approved these changes

Assignees

@wangela wangela

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add the ability to filter place reviews by newest.

3 participants

@nnolan @googlemaps-bot @wangela