fix : google-maps-services-java#697 missing URL in check for ApiException by PratikBorhade302 · Pull Request #711 · googlemaps/google-maps-services-java · GitHub
Skip to content

fix : google-maps-services-java#697 missing URL in check for ApiException#711

Merged
jpoehnelt merged 1 commit into
googlemaps:masterfrom
PratikBorhade302:patch-2
Jan 28, 2021
Merged

fix : google-maps-services-java#697 missing URL in check for ApiException#711
jpoehnelt merged 1 commit into
googlemaps:masterfrom
PratikBorhade302:patch-2

Conversation

@PratikBorhade302

@PratikBorhade302 PratikBorhade302 commented Jan 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

The URL is currently missing in the Check.
Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #697 🦕

@PratikBorhade302
Update ApiException.java
4c3a735 
line number 52 . missing URL in the check
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 27, 2021
@PratikBorhade302 PratikBorhade302 changed the title Update ApiException.java fix : googlemaps#697 missing URL in check on line 52. ApiException.java Jan 27, 2021
giakhangdouble
giakhangdouble approved these changes Jan 27, 2021
View reviewed changes

@giakhangdouble giakhangdouble left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi làm sao tôi có thể thây đổi vượt quá hạn mục tôi cần thây đổi nó không xin cứu giúp

@PratikBorhade302 PratikBorhade302 changed the title fix : googlemaps#697 missing URL in check on line 52. ApiException.java fix : googlemaps#697 missing URL in check for ApiException Jan 27, 2021
@PratikBorhade302 PratikBorhade302 changed the title fix : googlemaps#697 missing URL in check for ApiException fix : google-maps-services-java#697 missing URL in check for ApiException Jan 27, 2021
@PratikBorhade302

PratikBorhade302 commented Jan 27, 2021

Copy link
Copy Markdown
Contributor Author

@jpoehnelt jpoehnelt assigned arriolac and unassigned jpoehnelt Jan 28, 2021
@jpoehnelt jpoehnelt requested a review from arriolac January 28, 2021 15:13
@jpoehnelt jpoehnelt merged commit 556b995 into googlemaps:master Jan 28, 2021
@googlemaps-bot

googlemaps-bot commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@PratikBorhade302

PratikBorhade302 commented Jan 28, 2021

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arriolac arriolac Awaiting requested review from arriolac
1 more reviewer
@giakhangdouble giakhangdouble giakhangdouble approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@arriolac arriolac

Labels

cla: yes This human has signed the Contributor License Agreement. released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Geocoding: API throws OverQueryLimitException instead of OverDailyLimitException

5 participants

@PratikBorhade302 @googlemaps-bot @giakhangdouble @arriolac @jpoehnelt