Support geolocation api and properties loading by avidoggy · Pull Request #53 · googlemaps/google-maps-services-java · GitHub
Skip to content

Support geolocation api and properties loading#53

Closed
avidoggy wants to merge 1 commit into
googlemaps:masterfrom
avidoggy:master
Closed

Support geolocation api and properties loading#53
avidoggy wants to merge 1 commit into
googlemaps:masterfrom
avidoggy:master

Conversation

@avidoggy

Copy link
Copy Markdown

Hi, I changed something following:

  1. Implement geolocation api based on
    https://developers.google.com/maps/documentation/business/geolocation/ .
  2. Now, developers could setup api key by properties.

Hopes update be useful.

Thanks,
Gavin Lin

1. Implement geolocation api based on
https://developers.google.com/maps/documentation/business/geolocation/ .
2. Not only setting api key in environment variable, but in java
properties file.
@markmcd

markmcd commented Dec 23, 2014

Copy link
Copy Markdown
Contributor

@avidoggy

Copy link
Copy Markdown
Author

Hi,
Thanks for your comment. I had signed the CLA and sorry that, this is my first contribution in GitHub, I don't know how to separate into two PRs. (>_<)
May I re-send the pull request twice ? If so, I will think again about HTTP Body type how to define and add JavaDoc of GeoBusiApiContext.
About GeoBusiApiContext, following are my considerations:

  1. I think that Google Api for Work was different with Google Map Api, so that they using same context to describe may be not good.
  2. I tried to don't define new context, but it was hard to let others or me to understand easily.

Merry Xmas and enjoy holiday ! (^_^)

@domesticmouse

Copy link
Copy Markdown
Contributor

Hey Gavin, sorry it's taken so long to circle back. Is this still useful? If yes, please update this patch so I can land it. Thanks!

@domesticmouse

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants