{{ message }}
This repository was archived by the owner on May 14, 2026. It is now read-only.
fix: Handle null server address#4165
Closed
blakeli0 wants to merge 3 commits into
Closed
Conversation
Contributor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where a null server address could cause problems by adding exception handling around server address and port parsing. The changes are logical and include a new test case to cover the fix. My feedback focuses on refining the exception handling to be more specific, which improves the robustness of the code by not suppressing critical system errors.
|
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of an invalid endpoint such as
localhost:-1, the current parsing logic returns null for server address. This PR made server address nullable. And added a null check for the port parsing.In addition, added a try catch for the whole parsing logic because serviceAddress and serverPort should only be used for obersevability and should not affect regular requests.