iframe-proxy

chingor13 · 2026-01-08T23:42:53Z

gemini-code-assist · 2026-01-08T23:43:04Z

Summary of Changes

Hello @chingor13, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the org.json:json library into the project's shared dependency management system. This ensures that any module requiring JSON parsing or generation capabilities can leverage a consistent and centrally managed version of this library, thereby resolving a reported issue.

Highlights

New Dependency Added: The org.json:json library has been introduced as a managed dependency within the third-party-dependencies POM.
Version Management: A new property json.version has been defined to manage the version of the org.json:json library, set to 20251224.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds the org.json:json dependency to the shared third-party dependencies POM. My main concern is the version specified for this new dependency, 20251224, which does not exist in Maven Central and will cause build failures. I've suggested updating it to the latest stable version. I've also included some suggestions to improve maintainability by keeping properties and dependencies sorted alphabetically in the POM file.

blakeli0

Do you mind adding org.json:json to the dependencies.txt and use the latest version 20251224 there? We use this file to test if our client libraries are compatible with the latest dependencies.

sonarqubecloud · 2026-01-09T20:12:51Z

Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-01-09T20:16:37Z

🤖 I have created a release *beep* *boop* --- <details><summary>2.65.0</summary> ## [2.65.0](v2.64.2...v2.65.0) (2026-01-12) ### Features * add org.json:json to third-party-dependencies pom ([#4047](#4047)) ([ffa432e](ffa432e)), closes [#4046](#4046) * remove dependency management of graal-sdk ([#4033](#4033)) ([ad05c34](ad05c34)) ### Bug Fixes * add api_version breadcrumb to client docs ([#4018](#4018)) ([a2b2179](a2b2179)) * Create a single S2AChannelCredentials per application ([#3989](#3989)) ([3758b43](3758b43)) * provide API to share the same background executor for channel po… ([#4030](#4030)) ([178182c](178182c)) ### Dependencies * update dependencies.txt for grpc-gcp to 1.9.0 ([#4025](#4025)) ([b68791d](b68791d)) * update google api dependencies ([#3917](#3917)) ([480cf13](480cf13)) * update google.http-client.version to 2.0.3 ([#4054](#4054)) ([b9a8c89](b9a8c89)) ### Documentation * Fix retry guide link in javadocs ([#4029](#4029)) ([b43f77c](b43f77c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Fixes #4046

🤖 I have created a release *beep* *boop* --- <details><summary>2.65.0</summary> ## [2.65.0](v2.64.2...v2.65.0) (2026-01-12) ### Features * add org.json:json to third-party-dependencies pom ([#4047](#4047)) ([ffa432e](ffa432e)), closes [#4046](#4046) * remove dependency management of graal-sdk ([#4033](#4033)) ([ad05c34](ad05c34)) ### Bug Fixes * add api_version breadcrumb to client docs ([#4018](#4018)) ([a2b2179](a2b2179)) * Create a single S2AChannelCredentials per application ([#3989](#3989)) ([3758b43](3758b43)) * provide API to share the same background executor for channel po… ([#4030](#4030)) ([178182c](178182c)) ### Dependencies * update dependencies.txt for grpc-gcp to 1.9.0 ([#4025](#4025)) ([b68791d](b68791d)) * update google api dependencies ([#3917](#3917)) ([480cf13](480cf13)) * update google.http-client.version to 2.0.3 ([#4054](#4054)) ([b9a8c89](b9a8c89)) ### Documentation * Fix retry guide link in javadocs ([#4029](#4029)) ([b43f77c](b43f77c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Fixes #4046

🤖 I have created a release *beep* *boop* --- <details><summary>2.65.0</summary> ## [2.65.0](v2.64.2...v2.65.0) (2026-01-12) ### Features * add org.json:json to third-party-dependencies pom ([#4047](#4047)) ([ffa432e](ffa432e)), closes [#4046](#4046) * remove dependency management of graal-sdk ([#4033](#4033)) ([ad05c34](ad05c34)) ### Bug Fixes * add api_version breadcrumb to client docs ([#4018](#4018)) ([a2b2179](a2b2179)) * Create a single S2AChannelCredentials per application ([#3989](#3989)) ([3758b43](3758b43)) * provide API to share the same background executor for channel po… ([#4030](#4030)) ([178182c](178182c)) ### Dependencies * update dependencies.txt for grpc-gcp to 1.9.0 ([#4025](#4025)) ([b68791d](b68791d)) * update google api dependencies ([#3917](#3917)) ([480cf13](480cf13)) * update google.http-client.version to 2.0.3 ([#4054](#4054)) ([b9a8c89](b9a8c89)) ### Documentation * Fix retry guide link in javadocs ([#4029](#4029)) ([b43f77c](b43f77c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- <details><summary>2.65.0</summary> ## [2.65.0](googleapis/sdk-platform-java@v2.64.2...v2.65.0) (2026-01-12) ### Features * add org.json:json to third-party-dependencies pom ([#4047](googleapis/sdk-platform-java#4047)) ([5898abd](googleapis/sdk-platform-java@5898abd)), closes [#4046](googleapis/sdk-platform-java#4046) * remove dependency management of graal-sdk ([#4033](googleapis/sdk-platform-java#4033)) ([09ec2a3](googleapis/sdk-platform-java@09ec2a3)) ### Bug Fixes * add api_version breadcrumb to client docs ([#4018](googleapis/sdk-platform-java#4018)) ([0573232](googleapis/sdk-platform-java@0573232)) * Create a single S2AChannelCredentials per application ([#3989](googleapis/sdk-platform-java#3989)) ([6a24164](googleapis/sdk-platform-java@6a24164)) * provide API to share the same background executor for channel po… ([#4030](googleapis/sdk-platform-java#4030)) ([051f76a](googleapis/sdk-platform-java@051f76a)) ### Dependencies * update dependencies.txt for grpc-gcp to 1.9.0 ([#4025](googleapis/sdk-platform-java#4025)) ([2376f6c](googleapis/sdk-platform-java@2376f6c)) * update google api dependencies ([#3917](googleapis/sdk-platform-java#3917)) ([bf94a0a](googleapis/sdk-platform-java@bf94a0a)) * update google.http-client.version to 2.0.3 ([#4054](googleapis/sdk-platform-java#4054)) ([343a8ef](googleapis/sdk-platform-java@343a8ef)) ### Documentation * Fix retry guide link in javadocs ([#4029](googleapis/sdk-platform-java#4029)) ([4bb3ccc](googleapis/sdk-platform-java@4bb3ccc)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

feat: add org.json:json to third-party-dependencies pom

d3453b3

chingor13 requested a review from blakeli0 January 8, 2026 23:42

product-auto-label Bot added the size: xs Pull request size is extra small. label Jan 8, 2026

gemini-code-assist Bot reviewed Jan 8, 2026

View reviewed changes

Comment thread java-shared-dependencies/third-party-dependencies/pom.xml Outdated

Comment thread java-shared-dependencies/third-party-dependencies/pom.xml Outdated

Comment thread java-shared-dependencies/third-party-dependencies/pom.xml Outdated

reorder dependencies

77bd458

chingor13 mentioned this pull request Jan 9, 2026

fix(deps): update org.json:json to 20251224 googleapis/java-bigquerystorage#3170

Closed

blakeli0 reviewed Jan 9, 2026

View reviewed changes

Comment thread java-shared-dependencies/third-party-dependencies/pom.xml Outdated

blakeli0 reviewed Jan 9, 2026

View reviewed changes

chingor13 added 2 commits January 9, 2026 09:45

Update dependencies.txt

280521f

use 20250517 which is the current version used

10a9774

blakeli0 reviewed Jan 9, 2026

View reviewed changes

Comment thread dependencies.txt Outdated

use latest in dependencies.txt

7ea6d48

blakeli0 approved these changes Jan 9, 2026

View reviewed changes

blakeli0 merged commit ffa432e into main Jan 9, 2026
62 of 65 checks passed

blakeli0 deleted the add-json branch January 9, 2026 20:57

This was referenced Jan 9, 2026

chore(main): release 2.65.0 #4020

Closed

chore(main): release 2.65.0 #4058

Merged

diegomarquezp pushed a commit that referenced this pull request Jan 21, 2026

feat: add org.json:json to third-party-dependencies pom (#4047)

61c1671

Fixes #4046

lqiu96 pushed a commit that referenced this pull request Feb 12, 2026

feat: add org.json:json to third-party-dependencies pom (#4047)

ba3e2e6

Fixes #4046

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add org.json:json to third-party-dependencies pom#4047

feat: add org.json:json to third-party-dependencies pom#4047
blakeli0 merged 5 commits into
mainfrom
add-json

chingor13 commented Jan 8, 2026

Uh oh!

gemini-code-assist Bot commented Jan 8, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blakeli0 left a comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jan 9, 2026

Uh oh!

sonarqubecloud Bot commented Jan 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

chingor13 commented Jan 8, 2026

Uh oh!

gemini-code-assist Bot commented Jan 8, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blakeli0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jan 9, 2026

Quality Gate passed for 'gapic-generator-java-root'

Uh oh!

sonarqubecloud Bot commented Jan 9, 2026

Quality Gate passed for 'java_showcase_integration_tests'

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants