feat(samples): add argparse and clarify traversal support in download_many snippet by chandra-siri · Pull Request #1775 · googleapis/python-storage · GitHub
Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat(samples): add argparse and clarify traversal support in download_many snippet#1775

Merged
chandra-siri merged 11 commits into
mainfrom
update-download-many-snippet
Mar 18, 2026
Merged

feat(samples): add argparse and clarify traversal support in download_many snippet#1775
chandra-siri merged 11 commits into
mainfrom
update-download-many-snippet

Conversation

@chandra-siri

Copy link
Copy Markdown
Collaborator

This PR adds argparse support to the download_many snippet for CLI testing, and updates the description containing traversal safety.

@chandra-siri chandra-siri requested review from a team as code owners March 17, 2026 16:27
@chandra-siri chandra-siri requested review from vchudnov-g and removed request for a team March 17, 2026 16:27
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Mar 17, 2026
@product-auto-label product-auto-label Bot added api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Mar 17, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces argparse support for the download_many snippet, making it easier to use from the command line. It also updates comments to clarify the handling of directory traversal, improving security awareness. Additionally, the result handling is improved to account for warnings, such as when a download is skipped. My review includes a suggestion to fix an issue in a print statement to ensure the displayed download path is correct.

Comment thread samples/snippets/storage_transfer_manager_download_many.py Outdated
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Mar 17, 2026
@chandra-siri chandra-siri force-pushed the update-download-many-snippet branch from ed16238 to 40157de Compare March 17, 2026 17:20
Base automatically changed from skip_invalid_windows_path to main March 18, 2026 13:40
@chandra-siri chandra-siri requested review from a team as code owners March 18, 2026 13:40
@chandra-siri chandra-siri enabled auto-merge (squash) March 18, 2026 14:35
@chandra-siri chandra-siri merged commit 21bb20f into main Mar 18, 2026
15 checks passed
@chandra-siri chandra-siri deleted the update-download-many-snippet branch March 18, 2026 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants