{{ message }}
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
feat(samples): add argparse and clarify traversal support in download_many snippet#1775
Merged
Conversation
…load_many_to_path
… in download_many_to_path
Contributor
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces argparse support for the download_many snippet, making it easier to use from the command line. It also updates comments to clarify the handling of directory traversal, improving security awareness. Additionally, the result handling is improved to account for warnings, such as when a download is skipped. My review includes a suggestion to fix an issue in a print statement to ensure the displayed download path is correct.
…nload_many snippet
ed16238 to
40157de
Compare
krishnamd-jkp
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds argparse support to the download_many snippet for CLI testing, and updates the description containing traversal safety.