{{ message }}
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
chore: skip hmac tests until b/493225655 is fixed#1771
Merged
Conversation
product-auto-label
Bot
added
size: s
Contributor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds logic to skip HMAC tests when they fail due to a specific organization policy. The implementation in the new_hmac_key fixture is mostly correct, and I've suggested a small improvement for re-raising exceptions to preserve the stack trace. Additionally, test_create_key was missed and will still fail; I've provided a suggestion to apply the same skipping logic there to ensure all relevant tests are skipped as intended.
nidhiii-27
force-pushed
the
skip-hmac-tests
branch
from
88a19a5 to
96612b5
Compare
chandra-siri
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping hmac tests if they fail with a 412 PreconditionFailed. This is occurring because the testing project python-docs-samples-tests has the constraints/iam.disableServiceAccountKeyCreation Organization Policy enforced.