{{ message }}
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
chore: add depreciation warning for generation_number#1740
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a deprecation warning for the generation_number parameter in AsyncMultiRangeDownloader, correctly guiding users towards using the generation parameter instead. The implementation adds a logger.warning and is accompanied by an updated test case that properly verifies the new warning mechanism using caplog. The changes are straightforward, well-tested, and effectively address the goal of deprecating the parameter.
Contributor
Author
fbcb16f to
fe817bb
Compare
chandra-siri
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add a warning that generation_number will be deprecated in the next major release.