chore: add depreciation warning for generation_number by Pulkit0110 · Pull Request #1740 · googleapis/python-storage · GitHub
Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

chore: add depreciation warning for generation_number#1740

Merged
Pulkit0110 merged 4 commits into
googleapis:mainfrom
Pulkit0110:add-warning
Feb 4, 2026
Merged

chore: add depreciation warning for generation_number#1740
Pulkit0110 merged 4 commits into
googleapis:mainfrom
Pulkit0110:add-warning

Conversation

@Pulkit0110

Copy link
Copy Markdown
Contributor

Add a warning that generation_number will be deprecated in the next major release.

@Pulkit0110 Pulkit0110 requested review from a team February 3, 2026 07:30
@Pulkit0110 Pulkit0110 requested a review from a team as a code owner February 3, 2026 07:30
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Feb 3, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

@Pulkit0110 Pulkit0110 enabled auto-merge (squash) February 3, 2026 07:30

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a deprecation warning for the generation_number parameter in AsyncMultiRangeDownloader, correctly guiding users towards using the generation parameter instead. The implementation adds a logger.warning and is accompanied by an updated test case that properly verifies the new warning mechanism using caplog. The changes are straightforward, well-tested, and effectively address the goal of deprecating the parameter.

@Pulkit0110

Copy link
Copy Markdown
Contributor Author

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 4, 2026
@Pulkit0110 Pulkit0110 merged commit d9b1923 into googleapis:main Feb 4, 2026
18 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants