chore(tests): add test for reading unfinalized appendable objects with generation by chandra-siri · Pull Request #1698 · googleapis/python-storage · GitHub
Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

chore(tests): add test for reading unfinalized appendable objects with generation#1698

Merged
chandra-siri merged 3 commits into
mainfrom
more_sys_tests
Dec 31, 2025
Merged

chore(tests): add test for reading unfinalized appendable objects with generation#1698
chandra-siri merged 3 commits into
mainfrom
more_sys_tests

Conversation

@chandra-siri

Copy link
Copy Markdown
Collaborator

chore(tests): add test for reading unfinalized appendable objects with generation

@chandra-siri chandra-siri requested review from a team December 31, 2025 08:19
@chandra-siri chandra-siri requested a review from a team as a code owner December 31, 2025 08:19
@chandra-siri chandra-siri enabled auto-merge (squash) December 31, 2025 08:19
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Dec 31, 2025
@gemini-code-assist

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds a system test for reading unfinalized appendable objects with a specified generation. The test logic is sound and covers the intended scenario. I've suggested a refactoring to improve code reuse and ensure proper resource cleanup within the test.

Comment thread tests/system/test_zonal.py
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 31, 2025
@chandra-siri chandra-siri merged commit 0c35d3f into main Dec 31, 2025
17 checks passed
@chandra-siri chandra-siri deleted the more_sys_tests branch December 31, 2025 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants