{{ message }}
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
feat(storage): Add async client and async http iterator class#1696
Merged
Conversation
product-auto-label
Bot
added
size: l
Contributor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an experimental asynchronous client for Google Cloud Storage, along with an async HTTP iterator. The implementation looks solid and follows the patterns of the synchronous client. The tests are also comprehensive.
I've left a few comments for improvement:
- A few minor style issues like typos in comments, extra blank lines, and trailing whitespace.
- A suggestion to refactor
_list_resourceto be a synchronous method since it doesn't perform any awaitable operations, which would be a cleaner design. - Some improvements to type hints and defensive copying of parameters.
- A misplaced import in one of the test files.
Overall, great work on adding async support!
googlyrahman
force-pushed
the
dev-1
branch
5 times, most recently
from
9162e46 to
d2460df
Compare
chandra-siri
approved these changes
Dec 26, 2025
googlyrahman
added a commit
to googlyrahman/python-storage
that referenced
this pull request
Feb 5, 2026
…oogleapis#1696) 1. Add async client implementation. 2. Add AsyncHTTPIterator deriving from google.api_core.page_iterator_async.AsyncIterator as an alternative to google.api_core.page_iterator.HTTPIterator The AsyncHTTPIterator doesn't exists, and hence needs to be implemented.
googlyrahman
added a commit
to googlyrahman/python-storage
that referenced
this pull request
Feb 19, 2026
…oogleapis#1696) 1. Add async client implementation. 2. Add AsyncHTTPIterator deriving from google.api_core.page_iterator_async.AsyncIterator as an alternative to google.api_core.page_iterator.HTTPIterator The AsyncHTTPIterator doesn't exists, and hence needs to be implemented.
googlyrahman
added a commit
to googlyrahman/python-storage
that referenced
this pull request
Feb 19, 2026
…oogleapis#1696) 1. Add async client implementation. 2. Add AsyncHTTPIterator deriving from google.api_core.page_iterator_async.AsyncIterator as an alternative to google.api_core.page_iterator.HTTPIterator The AsyncHTTPIterator doesn't exists, and hence needs to be implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AsyncHTTPIterator doesn't exists, and hence needs to be implemented.