Revert "skip notification tests until b/470069573 is fixed" by chandra-siri · Pull Request #1694 · googleapis/python-storage · GitHub
Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

Revert "skip notification tests until b/470069573 is fixed"#1694

Merged
chandra-siri merged 2 commits into
mainfrom
bring_back_notification_tests
Dec 23, 2025
Merged

Revert "skip notification tests until b/470069573 is fixed"#1694
chandra-siri merged 2 commits into
mainfrom
bring_back_notification_tests

Conversation

@chandra-siri

Copy link
Copy Markdown
Collaborator

Revert "skip notification tests until b/470069573 is fixed"

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/python-storage API. labels Dec 23, 2025
@gemini-code-assist

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous commit that skipped several notification system tests pending a fix for an underlying issue. By removing the @pytest.mark.skip decorators, these tests are re-enabled, which is a positive step towards restoring full test coverage. The change is straightforward and appears correct, assuming the original issue b/470069573 has been resolved.

@chandra-siri chandra-siri marked this pull request as ready for review December 23, 2025 06:31
@chandra-siri chandra-siri requested review from a team December 23, 2025 06:31
@chandra-siri chandra-siri requested a review from a team as a code owner December 23, 2025 06:31
@chandra-siri chandra-siri enabled auto-merge (squash) December 23, 2025 06:31
@chandra-siri chandra-siri merged commit a994dbf into main Dec 23, 2025
17 checks passed
@chandra-siri chandra-siri deleted the bring_back_notification_tests branch December 23, 2025 06:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants