chore: add system 3.9 tests as required by chandra-siri · Pull Request #1670 · googleapis/python-storage · GitHub
Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

chore: add system 3.9 tests as required#1670

Merged
chandra-siri merged 5 commits into
mainfrom
chore_add_sys_39
Dec 17, 2025
Merged

chore: add system 3.9 tests as required#1670
chandra-siri merged 5 commits into
mainfrom
chore_add_sys_39

Conversation

@chandra-siri

Copy link
Copy Markdown
Collaborator

chore: add system 3.9 tests as required

@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Dec 17, 2025
@gemini-code-assist

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds the 'Kokoro system-3.9' status check to the branch protection rules, which directly addresses the stated goal of incorporating system 3.9 tests. Additionally, the comment in the presubmit.cfg file has been updated for improved clarity regarding the disabling of system tests. However, a significant change involves the removal of the python2 branch protection rule. This modification is not explicitly mentioned in the pull request description and appears to be unrelated to the primary objective of adding system 3.9 tests. This could potentially leave active python2 branches unprotected, which warrants further consideration.

Comment thread .github/sync-repo-settings.yaml
@chandra-siri chandra-siri marked this pull request as ready for review December 17, 2025 14:15
@chandra-siri chandra-siri requested review from a team December 17, 2025 14:15
@chandra-siri chandra-siri requested a review from a team as a code owner December 17, 2025 14:15
@chandra-siri chandra-siri merged commit b8855b0 into main Dec 17, 2025
16 of 17 checks passed
@chandra-siri chandra-siri deleted the chore_add_sys_39 branch December 17, 2025 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants