{{ message }}
This repository was archived by the owner on Jun 8, 2026. It is now read-only.
fix: executemany() should return every executed query result#551
Closed
IlyaFaer wants to merge 11 commits into
Closed
fix: executemany() should return every executed query result#551IlyaFaer wants to merge 11 commits into
IlyaFaer wants to merge 11 commits into
Conversation
IlyaFaer
added
type: bug
google-cla
Bot
added
the
cla: yes
c24t
reviewed
Nov 4, 2020
c24t
left a comment
c24t
left a comment
Contributor
There was a problem hiding this comment.
Comments about setting the result set and row count.
Chaining the result sets from each execute call looks sane to me, but FWIW PEP 249 makes it sound like this isn't the typical use:
Use of this method for an operation which produces one or more result sets constitutes undefined behavior, and the implementation is permitted (but not required) to raise an exception when it detects that a result set has been created by an invocation of the operation.
executemany shouldn't allow DDL right? I ask because it looks like execute queues up DDL statements without executing them and only calls update_ddl on the next non-DDL call. Also sqlite disallows this.
c24t
reviewed
Nov 4, 2020
Co-authored-by: Chris Kleinknecht <libc@google.com>
Author
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #518