{{ message }}
This repository was archived by the owner on Jun 8, 2026. It is now read-only.
test: make system test timeout configurable and default to 60 seconds#217
Merged
Conversation
product-auto-label
Bot
added
the
api: spanner
google-cla
Bot
added
the
cla: yes
arithmetic1728
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
larkee
reviewed
Feb 2, 2021
larkee
left a comment
larkee
left a comment
Contributor
There was a problem hiding this comment.
LGTM with a minor change to the flag name 👍
We have actually also encountered this flake on the repo but I haven't had time to investigate. In light of this, I would maybe suggest doubling the default value to 60.
Thank you very much for making this PR!
Contributor
Author
larkee
approved these changes
Feb 2, 2021
larkee
left a comment
larkee
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Please update the PR description to mention the default is now 60 seconds.
arithmetic1728
changed the title
larkee
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/173067462
It seems 30 seconds are too short for mtls test (which uses the system test, and runs on an internal platform). This makes the mtls test very flaky. This PR introduces a
SPANNER_OPERATION_TIMEOUT_IN_SECONDSenv var to make the timeout configurable.The default value is now 60 seconds.