iframe-proxy

sinhasubham · 2025-11-24T04:18:10Z

Make built-in metrics enabled by default

This change inverts the logic for enabling built-in OpenTelemetry metrics. Previously, metrics were disabled by default and could be enabled by setting ENABLE_SPANNER_METRICS_ENV_VAR=true.

With this update, metrics are now enabled by default to provide better out-of-the-box observability for users.

To disable metrics, users must now set the new environment variable:
SPANNER_DISABLE_BUILTIN_METRICS=true

The old ENABLE_SPANNER_METRICS_ENV_VAR is no longer used. Unit tests have been updated to reflect this new opt-out behavior.

BREAKING CHANGE: Built-in metrics are now enabled by default. Users who previously did not set any environment variables will have metrics collection and export turned on automatically after upgrading. To restore the previous behavior and disable metrics, thry have to set the SPANNER_DISABLE_BUILTIN_METRICS environment variable to true.

gemini-code-assist · 2025-11-24T04:18:26Z

Summary of Changes

Hello @sinhasubham, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the out-of-the-box observability for Spanner users by enabling built-in OpenTelemetry metrics by default. The change shifts the control mechanism from an opt-in model to an opt-out model, simplifying metric collection for most users while still providing a clear way to disable them if needed.

Highlights

Default Metrics Behavior: Built-in OpenTelemetry metrics are now enabled by default, inverting the previous opt-in behavior to provide better out-of-the-box observability.
New Opt-Out Mechanism: Users can now disable metrics by setting the new environment variable SPANNER_DISABLE_BUILTIN_METRICS=true.
Deprecated Environment Variable: The old ENABLE_SPANNER_METRICS_ENV_VAR is no longer used and has been removed from the codebase.
Breaking Change: This change is a breaking change as metrics will automatically be collected and exported for users who previously did not set any environment variables. To restore the previous behavior, the new SPANNER_DISABLE_BUILTIN_METRICS environment variable must be set to true.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly inverts the logic for enabling built-in metrics, making them on by default, which is a great improvement for out-of-the-box observability. The changes to the environment variable and the corresponding updates in the client logic and unit tests are clear and well-executed. I've noted one minor point about a leftover constant that could be cleaned up to improve maintainability.

surbhigarg92 · 2025-11-24T08:44:17Z


 def _get_spanner_enable_builtin_metrics():
-    return os.getenv(ENABLE_SPANNER_METRICS_ENV_VAR) == "true"
+    return os.getenv(SPANNER_DISABLE_BUILTIN_METRICS_ENV_VAR) != "true"


Since we are making Metrics default enabled with this changes, please make sure that metrics are not enabled when emulator is enabled and when customers use NoCredentials

Check https://github.com/googleapis/java-spanner/blob/main/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java#L2088

yes these cases are getting handled.
Emulator condition: https://github.com/googleapis/python-spanner/blob/main/google/cloud/spanner_v1/client.py#L257

NoCredential user condition: https://github.com/googleapis/python-spanner/blob/main/google/cloud/spanner_v1/client.py#L224-L225
This sets emulator setting for NoCredentials users making them act like emulator which means disabled metrics.

surbhigarg92 · 2025-11-24T08:48:26Z

Please see if we can also add Integration test for these metrics like https://github.com/googleapis/java-spanner/blob/main/google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITBuiltInMetricsTest.java#L89

sinhasubham · 2025-12-04T05:57:18Z

Got a confirmation from @surbhigarg92 that unexpected enabling of metrics for customers who did not set ENABLE_SPANNER_METRICS_ENV_VAR previously is not a breaking change and can be merged. Merging this PR.

Make built-in metrics enabled by default This change inverts the logic for enabling built-in OpenTelemetry metrics. Previously, metrics were disabled by default and could be enabled by setting `ENABLE_SPANNER_METRICS_ENV_VAR=true`. With this update, metrics are now enabled by default to provide better out-of-the-box observability for users. To disable metrics, users must now set the new environment variable: `SPANNER_DISABLE_BUILTIN_METRICS=true` The old `ENABLE_SPANNER_METRICS_ENV_VAR` is no longer used. Unit tests have been updated to reflect this new opt-out behavior. **BREAKING CHANGE**: Built-in metrics are now enabled by default. Users who previously did not set any environment variables will have metrics collection and export turned on automatically after upgrading. To restore the previous behavior and disable metrics, thry have to set the `SPANNER_DISABLE_BUILTIN_METRICS` environment variable to `true`.

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v1.0.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91 <details><summary>google-cloud-spanner: 3.60.0</summary> ## [3.60.0](https://togithub.com/googleapis/python-spanner/compare/v3.59.0...v3.60.0) (2025-12-10) ### Features * make built-in metrics enabled by default (#1459) ([64aebe7](https://togithub.com/googleapis/python-spanner/commit/64aebe7e)) * Exposing AutoscalingConfig in InstancePartition ([8b6f154](https://togithub.com/googleapis/python-spanner/commit/8b6f1540)) * add support for experimental host (#1452) ([9535e5e](https://togithub.com/googleapis/python-spanner/commit/9535e5e0)) * enable OpenTelemetry metrics and tracing by default (#1410) ([bb5095d](https://togithub.com/googleapis/python-spanner/commit/bb5095df)) * add cloud.region, request_tag and transaction_tag in span attributes (#1449) ([d37fb80](https://togithub.com/googleapis/python-spanner/commit/d37fb80a)) * Add QueryAdvisorResult for query plan (PiperOrigin-RevId: 832425466) ([e08260f](https://togithub.com/googleapis/python-spanner/commit/e08260fe)) * Add Send and Ack mutations for Queues (PiperOrigin-RevId: 832425466) ([e08260f](https://togithub.com/googleapis/python-spanner/commit/e08260fe)) * Add Spanner location API (#1457) (PiperOrigin-RevId: 833474957) ([e08260f](https://togithub.com/googleapis/python-spanner/commit/e08260fe)) ### Bug Fixes * Deprecate credentials_file argument ([8b6f154](https://togithub.com/googleapis/python-spanner/commit/8b6f1540)) * configure keepAlive time for gRPC TCP connections (#1448) ([efb2833](https://togithub.com/googleapis/python-spanner/commit/efb2833e)) * Provide Spanner Option to disable metrics (#1460) ([f1ebc43](https://togithub.com/googleapis/python-spanner/commit/f1ebc43b)) ### Documentation * Update description for the BatchCreateSessionsRequest and Session (PiperOrigin-RevId: 832425466) ([e08260f](https://togithub.com/googleapis/python-spanner/commit/e08260fe)) * Update description for the IsolationLevel (PiperOrigin-RevId: 832425466) ([e08260f](https://togithub.com/googleapis/python-spanner/commit/e08260fe)) </details>

ericzundel · 2026-01-24T12:14:40Z

feat(spanner): make built-in metrics enabled by default

6abe73f

sinhasubham requested review from a team November 24, 2025 04:18

blunderbuss-gcf Bot assigned aakashanandg Nov 24, 2025

product-auto-label Bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/python-spanner API. labels Nov 24, 2025

gemini-code-assist Bot reviewed Nov 24, 2025

View reviewed changes

Comment thread google/cloud/spanner_v1/client.py

surbhigarg92 reviewed Nov 24, 2025

View reviewed changes

product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 2, 2025

sinhasubham force-pushed the fix/builtin-metrics-env-var branch from 28abdfd to b13ea7b Compare December 2, 2025 10:20

feat(metrics): add system test for built-in metrics

63ca819

sinhasubham force-pushed the fix/builtin-metrics-env-var branch from b13ea7b to 63ca819 Compare December 2, 2025 11:19

surbhigarg92 approved these changes Dec 2, 2025

View reviewed changes

sinhasubham merged commit 64aebe7 into main Dec 4, 2025
22 checks passed

sinhasubham deleted the fix/builtin-metrics-env-var branch December 4, 2025 05:57

surbhigarg92 added the release-please:force-run To run release-please label Dec 9, 2025

release-please Bot removed the release-please:force-run To run release-please label Dec 9, 2025

surbhigarg92 added the release-please:force-run To run release-please label Dec 9, 2025

release-please Bot removed the release-please:force-run To run release-please label Dec 9, 2025

rahul2393 mentioned this pull request Dec 10, 2025

chore: librarian release pull request: 20251210T220651Z #1462

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(spanner): make built-in metrics enabled by default#1459

feat(spanner): make built-in metrics enabled by default#1459
sinhasubham merged 2 commits into
mainfrom
fix/builtin-metrics-env-var

sinhasubham commented Nov 24, 2025

Uh oh!

gemini-code-assist Bot commented Nov 24, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

surbhigarg92 Nov 24, 2025

Uh oh!

sinhasubham Nov 25, 2025

Uh oh!

surbhigarg92 commented Nov 24, 2025

Uh oh!

sinhasubham commented Dec 4, 2025

Uh oh!

Uh oh!

ericzundel commented Jan 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

sinhasubham commented Nov 24, 2025

Uh oh!

gemini-code-assist Bot commented Nov 24, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

surbhigarg92 Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

sinhasubham Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

surbhigarg92 commented Nov 24, 2025

Uh oh!

sinhasubham commented Dec 4, 2025

Uh oh!

Uh oh!

ericzundel commented Jan 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants