chore: Restore code coverage by bw-yuhogg · Pull Request #855 · googleapis/python-ndb · GitHub
Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

chore: Restore code coverage#855

Merged
parthea merged 1 commit into
googleapis:mainfrom
bw-yuhogg:restore-coverage
Dec 15, 2022
Merged

chore: Restore code coverage#855
parthea merged 1 commit into
googleapis:mainfrom
bw-yuhogg:restore-coverage

Conversation

@bw-yuhogg

Copy link
Copy Markdown
Contributor

Mostly get rid of older Py2-only code

@bw-yuhogg bw-yuhogg requested review from a team December 15, 2022 15:26
@product-auto-label product-auto-label Bot added the api: datastore Issues related to the googleapis/python-ndb API. label Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: it's easier to see that this change is correct if you view it with split-diffs and while ignoring whitespace changes

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fromstring is a deprecated alias for frombytes. Ditto for tostring vs. tobytes.

The string versions date from Py2 and were renamed and aliased in Py3 due to the bytes/string distinction. The aliases were removed in Python 3.9.

Mostly get rid of older Py2-only code
@bw-yuhogg bw-yuhogg changed the title DO NOT MERGE chore: Restore code coverage chore: Restore code coverage Dec 15, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 15, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 15, 2022
@parthea parthea enabled auto-merge (squash) December 15, 2022 17:08
@parthea parthea merged commit 15fcea2 into googleapis:main Dec 15, 2022
@bw-yuhogg bw-yuhogg deleted the restore-coverage branch December 15, 2022 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/python-ndb API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants