build: update README to indicate that source has moved by parthea · Pull Request #1038 · googleapis/python-ndb · GitHub
Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

build: update README to indicate that source has moved#1038

Merged
parthea merged 1 commit into
mainfrom
parthea-patch-2
Mar 6, 2026
Merged

build: update README to indicate that source has moved#1038
parthea merged 1 commit into
mainfrom
parthea-patch-2

Conversation

@parthea

@parthea parthea commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

@parthea parthea requested a review from a team March 6, 2026 17:19
@product-auto-label product-auto-label Bot added the api: datastore Issues related to the googleapis/python-ndb API. label Mar 6, 2026
@gemini-code-assist

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md to inform users that the repository has been archived and its contents moved. While the intent is correct, the added note uses reStructuredText (RST) syntax within a Markdown file. This will cause rendering issues on platforms like GitHub and PyPI. I've provided a suggestion to use proper Markdown syntax to ensure the note is displayed correctly.

Note: Security Review has been skipped due to the limited scope of the PR.

Comment thread README.md
Comment on lines +1 to +3
:**NOTE**: **This github repository is archived. The repository contents and history have moved to** `google-cloud-python`_.

.. _google-cloud-python: https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-ndb

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The README.md file is treated as Markdown, as indicated by its .md extension and its usage in setup.py with long_description_content_type="text/markdown". The current syntax for the note and link is reStructuredText (RST), which will not render correctly. To ensure the note is properly displayed on GitHub and PyPI, it should be converted to Markdown syntax. Using a blockquote will also help the note stand out.

Suggested change

@parthea parthea merged commit 55651c4 into main Mar 6, 2026
16 of 17 checks passed
@parthea parthea deleted the parthea-patch-2 branch March 6, 2026 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/python-ndb API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants