feat: add config based annotation converter by galdawave · Pull Request #72 · googleapis/python-documentai-toolbox · GitHub
Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: add config based annotation converter#72

Merged
holtskinner merged 28 commits into
mainfrom
converter-toolkit
Mar 9, 2023
Merged

feat: add config based annotation converter#72
holtskinner merged 28 commits into
mainfrom
converter-toolkit

Conversation

@galdawave

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@galdawave galdawave requested a review from a team as a code owner March 2, 2023 20:58
@galdawave galdawave requested review from a team and rsamborski March 2, 2023 20:58
@product-auto-label product-auto-label Bot added the size: xl Pull request size is extra large. label Mar 2, 2023
@galdawave galdawave added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 2, 2023

@holtskinner holtskinner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to keep looking at this, but these are my comments for now

Comment thread tests/unit/test_document.py
Comment thread google/cloud/documentai_toolbox/converters/config/converter_helpers.py Outdated
Comment thread google/cloud/documentai_toolbox/converters/config/converter_helpers.py Outdated
Comment thread google/cloud/documentai_toolbox/converters/config/converter_helpers.py Outdated
Comment thread google/cloud/documentai_toolbox/converters/config/converter_helpers.py Outdated
Comment thread google/cloud/documentai_toolbox/converters/config/converter_helpers.py Outdated
Comment thread tests/unit/test_bbox_conversion.py Outdated
Comment thread tests/unit/test_bbox_conversion.py Outdated
Comment thread google/cloud/documentai_toolbox/converters/config/converter_helpers.py Outdated
@galdawave galdawave requested a review from holtskinner March 6, 2023 23:32
@galdawave galdawave added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 7, 2023
@snippet-bot

snippet-bot Bot commented Mar 9, 2023

Copy link
Copy Markdown

Comment thread samples/snippets/convert_document_from_azure_sample.py Outdated
Comment thread samples/snippets/convert_document_from_azure_sample.py Outdated
Comment thread samples/snippets/convert_document_from_azure_sample.py
Comment thread samples/snippets/convert_document_from_azure_sample.py Outdated
Comment thread samples/snippets/convert_document_from_azure_sample.py Outdated
Comment thread samples/snippets/convert_document_from_azure_sample.py Outdated
Comment thread samples/snippets/convert_document_from_azure_sample.py Outdated
@holtskinner

Copy link
Copy Markdown
Contributor

galdawave and others added 4 commits March 9, 2023 13:29
Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
@galdawave galdawave removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 9, 2023
@holtskinner holtskinner merged commit 735514e into main Mar 9, 2023
@holtskinner holtskinner deleted the converter-toolkit branch March 9, 2023 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants