chore(deps): Remove Python 3.8 by holtskinner · Pull Request #398 · googleapis/python-documentai-toolbox · GitHub
Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

chore(deps): Remove Python 3.8#398

Closed
holtskinner wants to merge 23 commits into
mainfrom
remove-python38
Closed

chore(deps): Remove Python 3.8#398
holtskinner wants to merge 23 commits into
mainfrom
remove-python38

Conversation

@holtskinner

Copy link
Copy Markdown
Contributor

No description provided.

@holtskinner holtskinner requested a review from a team as a code owner February 5, 2026 20:13
@holtskinner holtskinner requested review from a team and glasnt and removed request for a team February 5, 2026 20:13
@product-auto-label product-auto-label Bot added the size: l Pull request size is large. label Feb 5, 2026
@holtskinner holtskinner assigned parthea and unassigned rosiezou Feb 5, 2026
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Feb 5, 2026
@gemini-code-assist

Copy link
Copy Markdown

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Feb 5, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to remove support for Python 3.8. While most of the changes correctly reflect this, there are a couple of critical issues in the repository settings that weaken branch protection by removing required CI checks for several Python versions. I've also pointed out a minor cleanup opportunity in one of the noxfiles for better maintainability. Please review the suggested changes to ensure CI coverage remains strong.

Comment thread .github/sync-repo-settings.yaml
Comment thread .github/sync-repo-settings.yaml
Comment thread samples/snippets/noxfile.py
Comment thread pytest.ini
Upgrade some of the regex to capture warnings that pytest can safely ignore.
@chalmerlowe

Copy link
Copy Markdown

Due to some issues with Python 3.9 and associated dependencies, we no longer have it in our python-multi image used by Kokoro. We rely on GitHub Actions to perform the 3.9-unit and system tests. I will suggest some edits to account for that.

@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Feb 27, 2026
Comment thread noxfile.py
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Feb 27, 2026
Comment thread noxfile.py Outdated
Comment thread testing/constraints-3.9.txt Outdated
@chalmerlowe

Copy link
Copy Markdown

📢 Migration Notice: 📢 This library is moving to the google-cloud-python monorepo soon.

We kept this PR open due to recent activity. We would like to finalize this PR so it can be merged if it is critical.

If we don't hear from the PR author, we will close this PR in the next few days. The PR can then be re-opened in the monorepo once the migration is complete and work can continue there.

@parthea

parthea commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

@parthea parthea closed this Mar 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants