chore(librarian): onboard to librarian by parthea · Pull Request #392 · googleapis/python-documentai-toolbox · GitHub
Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

chore(librarian): onboard to librarian#392

Closed
parthea wants to merge 7 commits into
mainfrom
onboard-to-librarian
Closed

chore(librarian): onboard to librarian#392
parthea wants to merge 7 commits into
mainfrom
onboard-to-librarian

Conversation

@parthea

@parthea parthea commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Dec 18, 2025
@parthea parthea added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed size: m Pull request size is medium. labels Dec 18, 2025
@gemini-code-assist

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the repository's release process from OwlBot to Librarian. This involves removing configuration files for OwlBot and other related release configurations, and adding a new configuration file for Librarian. The changes appear correct and align with the goal of onboarding to Librarian. I have one suggestion regarding the Docker image used in the Librarian configuration to improve build reproducibility.

Comment thread .librarian/state.yaml Outdated
@parthea

parthea commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

This PR depends on an unreleased fix in librarian (googleapis/librarian#3305). Do not merge this PR until the fix lands in automation.

@holtskinner

Copy link
Copy Markdown
Contributor

@parthea Is this ready to be merged now? Looks like googleapis/librarian#3305 is complete

@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 22, 2026
@parthea

parthea commented Jan 22, 2026

Copy link
Copy Markdown
Contributor Author

@holtskinner Yes, this is now ready for review.

Make sure to install legacylibrarian 0.8.0 which has the fix (instructions)

go install github.com/googleapis/librarian/cmd/legacylibrarian@v0.8.0

I also ran

export PATH="$PATH:/usr/local/google/home/$USER/go/bin"

and then

legacylibrarian release stage -library-version=0.16.0-alpha -library=google-cloud-documentai-toolbox

To validate the changes

Comment thread pytest.ini
ignore:The python-bigquery library will stop supporting Python 3.7 and Python 3.8:PendingDeprecationWarning
# This error is expected for python versions that approach EOL
ignore:.*Please upgrade to the latest Python version.*:FutureWarning
ignore:.*Please upgrade to the latest Python version.*:FutureWarning

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is a duplicate

@chalmerlowe

Copy link
Copy Markdown

@chalmerlowe chalmerlowe closed this Mar 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python-documentai-toolbox: release-please is broken

3 participants