feat: added text_annotation to vision conversion by galdawave · Pull Request #114 · googleapis/python-documentai-toolbox · GitHub
Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: added text_annotation to vision conversion#114

Merged
galdawave merged 5 commits into
googleapis:mainfrom
galdawave:vision-update
May 31, 2023
Merged

feat: added text_annotation to vision conversion#114
galdawave merged 5 commits into
googleapis:mainfrom
galdawave:vision-update

Conversation

@galdawave

@galdawave galdawave commented May 22, 2023

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@galdawave galdawave requested a review from holtskinner May 22, 2023 18:36
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label May 22, 2023
@galdawave galdawave marked this pull request as ready for review May 22, 2023 18:36
@galdawave galdawave requested review from a team May 22, 2023 18:36
xixiong
xixiong reviewed May 22, 2023
View reviewed changes
Comment thread google/cloud/documentai_toolbox/wrappers/document.py Outdated
xixiong
xixiong reviewed May 22, 2023
View reviewed changes
Comment thread tests/unit/test_document.py
@holtskinner holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
holtskinner
holtskinner approved these changes May 23, 2023
View reviewed changes
Comment thread google/cloud/documentai_toolbox/converters/vision_helpers.py Outdated
Comment thread google/cloud/documentai_toolbox/converters/vision_helpers.py Outdated
Comment thread google/cloud/documentai_toolbox/converters/vision_helpers.py Outdated
Comment thread google/cloud/documentai_toolbox/wrappers/document.py
Comment thread tests/unit/test_document.py
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels May 30, 2023
@galdawave galdawave requested a review from xixiong May 30, 2023 22:49
@galdawave galdawave added the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2023
@galdawave galdawave merged commit 27196bb into googleapis:main May 31, 2023
@galdawave galdawave deleted the vision-update branch May 31, 2023 16:52
@release-please release-please Bot mentioned this pull request May 31, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@xixiong xixiong xixiong approved these changes
@holtskinner holtskinner holtskinner approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@galdawave @xixiong @holtskinner