feat(gapic): support mTLS certificates when available by daniel-sanche · Pull Request #1249 · googleapis/python-bigtable · GitHub
Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

feat(gapic): support mTLS certificates when available#1249

Merged
parthea merged 2 commits intomainfrom
librarian-20251216T120124Z
Dec 16, 2025
Merged

feat(gapic): support mTLS certificates when available#1249
parthea merged 2 commits intomainfrom
librarian-20251216T120124Z

Conversation

@daniel-sanche
Copy link
Copy Markdown
Contributor

feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209

…prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
@daniel-sanche daniel-sanche requested review from a team December 16, 2025 20:01
@product-auto-label product-auto-label Bot added the size: xl Pull request size is extra large. label Dec 16, 2025
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Dec 16, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, generated by the librarian tool, updates the generator image and applies several beneficial changes across the library. Key improvements include:

  • Refactoring the mTLS client certificate logic into a centralized helper method (_use_client_cert_effective), which removes code duplication in the client classes.
  • Adding runtime checks for Python and google.protobuf versions to provide helpful warnings to users about potential incompatibilities.
  • Removing obsolete code-generation fixup scripts.
  • Adding comprehensive unit tests for the new mTLS logic.

The changes are consistent, well-tested, and improve the maintainability and user-friendliness of the library. The update looks good.

@daniel-sanche daniel-sanche changed the title chore: librarian update image pull request: 20251216T120124Z feat(gapic): support mTLS certificates when available Dec 16, 2025
@parthea parthea enabled auto-merge (squash) December 16, 2025 20:46
@parthea parthea merged commit ca20219 into main Dec 16, 2025
33 checks passed
@parthea parthea deleted the librarian-20251216T120124Z branch December 16, 2025 21:02
daniel-sanche added a commit that referenced this pull request Dec 16, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
<details><summary>google-cloud-bigtable: 2.35.0</summary>

##
[2.35.0](v2.34.0...v2.35.0)
(2025-12-16)

### Features

* add basic interceptor to client (#1206)
([6561cfa](6561cfac))

* Add encodings for STRUCT and the Timestamp type
([72dfdc4](72dfdc44))

* add PeerInfo proto in Bigtable API
([72dfdc4](72dfdc44))

* Add Type API updates needed to support structured keys in materialized
views
([72dfdc4](72dfdc44))

* support mTLS certificates when available (#1249)
([ca20219](ca20219c))

### Bug Fixes

* re-export AddToCell for consistency (#1241)
([2a5baf1](2a5baf11))

* async client uses fixed grace period (#1236)
([544db1c](544db1cd))

* Deprecate credentials_file argument
([72dfdc4](72dfdc44))

* Add ReadRows/SampleRowKeys bindings for materialized views
([72dfdc4](72dfdc44))

* retry cancelled errors (#1235)
([e3fd5d8](e3fd5d86))

</details>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants