{{ message }}
This repository was archived by the owner on May 7, 2026. It is now read-only.
feat: SQL Cell no longer escapes formatted string values#2245
Merged
Conversation
Updates `bigframes/core/pyformat.py` to directly embed string values in the formatted output. This allows for dynamic substitution of SQL identifiers, such as table or column names. Updated unit tests to reflect this new behavior by using valid SQL identifiers in the test cases.
Contributor
Author
product-auto-label
Bot
added
size: s
tswast
previously approved these changes
Nov 10, 2025
Contributor
|
@google-labs-jules It seems this may be related to this change. Please fix. |
Contributor
Author
You are right, that test was failing due to my changes. I have now fixed the test. Thank you for catching that! |
Contributor
Author
|
I have generated the requested changes, but I was unable to publish them to the branch. You can publish the changes manually from the Jules UI. |
This commit fixes a unit test that was failing due to the changes in pyformat. The test is updated to pass a pre-quoted string, ensuring the resulting SQL is valid.
Contributor
|
Remaining test should be fixed by #2246 |
Contributor
Author
Updates `bigframes/core/pyformat.py` to directly embed string values in the formatted output. This allows for dynamic substitution of SQL identifiers, such as table or column names. Updated unit tests to reflect this new behavior by using valid SQL identifiers in the test cases.
tswast
previously approved these changes
Nov 10, 2025
sycai
previously approved these changes
Nov 10, 2025
tswast
added
the
kokoro:force-run
bigframes-bot
removed
the
kokoro:force-run
tswast
approved these changes
Nov 10, 2025
sycai
approved these changes
Nov 10, 2025
tswast
added
the
kokoro:force-run
bigframes-bot
removed
the
kokoro:force-run
tswast
changed the title
sycai
pushed a commit
that referenced
this pull request
Nov 10, 2025
🤖 I have created a release *beep* *boop* --- ## [2.29.0](v2.28.0...v2.29.0) (2025-11-10) ### Features * Add bigframes.bigquery.st_regionstats to join raster data from Earth Engine ([#2228](#2228)) ([10ec52f](10ec52f)) * Add DataFrame.resample and Series.resample ([#2213](#2213)) ([c9ca02c](c9ca02c)) * SQL Cell no longer escapes formatted string values ([#2245](#2245)) ([d2d38f9](d2d38f9)) * Support left_index and right_index for merge ([#2220](#2220)) ([da9ba26](da9ba26)) ### Bug Fixes * Correctly iterate over null struct values in ManagedArrowTable ([#2209](#2209)) ([12e04d5](12e04d5)) * Simplify UnsupportedTypeError message ([#2212](#2212)) ([6c9a18d](6c9a18d)) * Support results with STRUCT and ARRAY columns containing JSON subfields in `to_pandas_batches()` ([#2216](#2216)) ([3d8b17f](3d8b17f)) ### Documentation * Switch API reference docs to pydata theme ([#2237](#2237)) ([9b86dcf](9b86dcf)) * Update notebook for JSON subfields support in to_pandas_batches() ([#2138](#2138)) ([5663d2a](5663d2a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Apr 1, 2026
🤖 I have created a release *beep* *boop* --- ## [2.29.0](googleapis/python-bigquery-dataframes@v2.28.0...v2.29.0) (2025-11-10) ### Features * Add bigframes.bigquery.st_regionstats to join raster data from Earth Engine ([#2228](googleapis/python-bigquery-dataframes#2228)) ([10ec52f](googleapis/python-bigquery-dataframes@10ec52f)) * Add DataFrame.resample and Series.resample ([#2213](googleapis/python-bigquery-dataframes#2213)) ([c9ca02c](googleapis/python-bigquery-dataframes@c9ca02c)) * SQL Cell no longer escapes formatted string values ([#2245](googleapis/python-bigquery-dataframes#2245)) ([d2d38f9](googleapis/python-bigquery-dataframes@d2d38f9)) * Support left_index and right_index for merge ([#2220](googleapis/python-bigquery-dataframes#2220)) ([da9ba26](googleapis/python-bigquery-dataframes@da9ba26)) ### Bug Fixes * Correctly iterate over null struct values in ManagedArrowTable ([#2209](googleapis/python-bigquery-dataframes#2209)) ([12e04d5](googleapis/python-bigquery-dataframes@12e04d5)) * Simplify UnsupportedTypeError message ([#2212](googleapis/python-bigquery-dataframes#2212)) ([6c9a18d](googleapis/python-bigquery-dataframes@6c9a18d)) * Support results with STRUCT and ARRAY columns containing JSON subfields in `to_pandas_batches()` ([#2216](googleapis/python-bigquery-dataframes#2216)) ([3d8b17f](googleapis/python-bigquery-dataframes@3d8b17f)) ### Documentation * Switch API reference docs to pydata theme ([#2237](googleapis/python-bigquery-dataframes#2237)) ([9b86dcf](googleapis/python-bigquery-dataframes@9b86dcf)) * Update notebook for JSON subfields support in to_pandas_batches() ([#2138](googleapis/python-bigquery-dataframes#2138)) ([5663d2a](googleapis/python-bigquery-dataframes@5663d2a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates bigframes/core/pyformat.py to directly embed str values rather than escaping them first. Unit tests have been updated to reflect this change.
PR created automatically by Jules for task 5189763854933796072