iframe-proxy

google-labs-jules · 2025-09-29T15:00:31Z

This change introduces the ExternalRuntimeOptions class to the
google.cloud.bigquery.routine module, allowing users to configure
runtime options for external routines.

Key changes:

Created the ExternalRuntimeOptions class with setters and getters for
container_memory, container_cpu, runtime_connection,
max_batching_rows, and runtime_version.
Updated the Routine class to include an external_runtime_options
property that accepts an ExternalRuntimeOptions object.
Added comprehensive unit tests for the new class and its integration
with the Routine class, including tests for both valid and invalid
input values.

Fixes #2240
Replaces PR #2305

PR created automatically by Jules for task 17042493298890483722

This change introduces the `ExternalRuntimeOptions` class to the `google.cloud.bigquery.routine` module, allowing users to configure runtime options for external routines. Key changes: - Created the `ExternalRuntimeOptions` class with setters and getters for `container_memory`, `container_cpu`, `runtime_connection`, `max_batching_rows`, and `runtime_version`. - Updated the `Routine` class to include an `external_runtime_options` property that accepts an `ExternalRuntimeOptions` object. - Added comprehensive unit tests for the new class and its integration with the `Routine` class, including tests for both valid and invalid input values.

google-labs-jules · 2025-09-29T15:00:32Z

This change introduces the `ExternalRuntimeOptions` class to the `google.cloud.bigquery.routine` module, allowing users to configure runtime options for external routines. Key changes: - Created the `ExternalRuntimeOptions` class with setters and getters for `container_memory`, `container_cpu`, `runtime_connection`, `max_batching_rows`, and `runtime_version`. - Updated the `Routine` class to include an `external_runtime_options` property that accepts an `ExternalRuntimeOptions` object. - Added comprehensive unit tests for the new class and its integration with the `Routine` class, including tests for both valid and invalid input values.

chalmerlowe · 2025-09-29T16:26:16Z

Jules:

We lack some coverage via unit tests.
Coverage indicates that we don't have coverage on lines 375-380, 816-818, 908, and 912. Please see what you can do to update the test suite.

google-labs-jules · 2025-09-29T16:28:30Z

Jules:

We lack some coverage via unit tests.
Coverage indicates that we don't have coverage on lines 375-380, 816-818, 908, and 912. Please see what you can do to update the test suite.

I have added new unit tests to cover the missing lines of code. The test suite now passes with 100% coverage for the new functionality.

This change introduces the `ExternalRuntimeOptions` class to the `google.cloud.bigquery.routine` module, allowing users to configure runtime options for external routines. Key changes: - Created the `ExternalRuntimeOptions` class with setters and getters for `container_memory`, `container_cpu`, `runtime_connection`, `max_batching_rows`, and `runtime_version`. - Updated the `Routine` class to include an `external_runtime_options` property that accepts an `ExternalRuntimeOptions` object. - Added comprehensive unit tests for the new class and its integration with the `Routine` class, including tests for both valid and invalid input values. - Added additional tests to improve code coverage based on feedback.

chalmerlowe · 2025-09-29T17:01:07Z

Jules:

PyType is making guesses about the types of some objects in the routine.py file.

Here are two examples.

/tmpfs/src/github/python-bigquery/google/cloud/bigquery/routine/routine.py:834:1: error: in container_memory: bad option 'int' in return type [bad-return-type]
           Expected: Optional[str]
  Actually returned: Optional[Any]

        return self._properties.get("containerMemory")~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        return self._properties.get("containerMemory")


/tmpfs/src/github/python-bigquery/google/cloud/bigquery/routine/routine.py:856:1: error: in runtime_connection: bad option 'int' in return type [bad-return-type]
           Expected: Optional[str]
  Actually returned: Optional[Any]

        return self._properties.get("runtimeConnection")~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        return self._properties.get("runtimeConnection")

Any suggestions?

google-labs-jules · 2025-09-29T17:03:12Z

Jules:

PyType is making guesses about the types of some objects in the routine.py file.

Here are two examples.

/tmpfs/src/github/python-bigquery/google/cloud/bigquery/routine/routine.py:834:1: error: in container_memory: bad option 'int' in return type [bad-return-type]
           Expected: Optional[str]
  Actually returned: Optional[Any]

        return self._properties.get("containerMemory")~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        return self._properties.get("containerMemory")


/tmpfs/src/github/python-bigquery/google/cloud/bigquery/routine/routine.py:856:1: error: in runtime_connection: bad option 'int' in return type [bad-return-type]
           Expected: Optional[str]
  Actually returned: Optional[Any]

        return self._properties.get("runtimeConnection")~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        return self._properties.get("runtimeConnection")

Any suggestions?

I have applied the suggested changes to address the type-checking errors. The tests all pass, and the code should now be free of any type-related issues.

This change introduces the `ExternalRuntimeOptions` class to the `google.cloud.bigquery.routine` module, allowing users to configure runtime options for external routines. Key changes: - Created the `ExternalRuntimeOptions` class with setters and getters for `container_memory`, `container_cpu`, `runtime_connection`, `max_batching_rows`, and `runtime_version`. - Updated the `Routine` class to include an `external_runtime_options` property that accepts an `ExternalRuntimeOptions` object. - Added comprehensive unit tests for the new class and its integration with the `Routine` class, including tests for both valid and invalid input values. - Added additional tests to improve code coverage based on feedback. - Addressed PyType errors by using helper functions for type conversion.

This change introduces the `ExternalRuntimeOptions` class to the `google.cloud.bigquery.routine` module, allowing users to configure runtime options for external routines. Key changes: - Created the `ExternalRuntimeOptions` class with setters and getters for `container_memory`, `container_cpu`, `runtime_connection`, `max_batching_rows`, and `runtime_version`. - Updated the `Routine` class to include an `external_runtime_options` property that accepts an `ExternalRuntimeOptions` object. - Added comprehensive unit tests for the new class and its integration with the `Routine` class, including tests for both valid and invalid input values. - Added additional tests to improve code coverage based on feedback. - Addressed PyType errors by using helper functions for type conversion. - Addressed formatting nits from code review.

Linchin · 2025-10-01T21:32:15Z

+        runtime_connection: Optional[str] = None,
+        max_batching_rows: Optional[int] = None,
+        runtime_version: Optional[str] = None,
+        _properties: Optional[Dict] = None,


I wonder if this is necessary?

Linchin

Approved with a minor comment

gcf-merge-on-green · 2025-10-02T17:52:22Z

chalmerlowe

LGTM

chalmerlowe

LGTM

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620 <details><summary>google-cloud-bigquery: 3.39.0</summary> ## [3.39.0](v3.38.0...v3.39.0) (2025-12-12) ### Features * adds support for Python runtime 3.14 (#2322) ([6065e14](6065e14c)) * Add ExternalRuntimeOptions to BigQuery routine (#2311) ([fa76e31](fa76e310)) ### Bug Fixes * remove ambiguous error codes from query retries (#2308) ([8bbd3d0](8bbd3d01)) * include `io.Base` in the `PathType` (#2323) ([b11e09c](b11e09cb)) * honor custom `retry` in `job.result()` (#2302) ([e118b02](e118b029)) ### Documentation * remove experimental annotations from GA features (#2303) ([1f1f9d4](1f1f9d41)) </details> Co-authored-by: Daniel Sanche <d.sanche14@gmail.com>

product-auto-label Bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery API. labels Sep 29, 2025

chalmerlowe self-assigned this Sep 29, 2025

chalmerlowe marked this pull request as ready for review September 29, 2025 16:13

chalmerlowe requested review from a team and logachev September 29, 2025 16:13

chalmerlowe reviewed Sep 29, 2025

View reviewed changes

Comment thread google/cloud/bigquery/routine/routine.py

chalmerlowe and others added 2 commits September 29, 2025 12:16

Update google/cloud/bigquery/routine/routine.py

d2731de

chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 29, 2025

yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 29, 2025

chalmerlowe mentioned this pull request Sep 29, 2025

feat: Expose remote function options (maxBatchingRows, containerCpu, containerMemory) as first class properties #2305

Closed

chalmerlowe reviewed Sep 30, 2025

View reviewed changes

Comment thread tests/unit/routine/test_external_runtime_options.py Outdated

chalmerlowe and others added 3 commits September 30, 2025 05:56

Update tests/unit/routine/test_external_runtime_options.py

01457a5

Merge branch 'main' into feat-external-runtime-options

f597f7f

chalmerlowe added the automerge Merge the pull request once unit tests and other checks pass. label Oct 1, 2025

Merge branch 'main' into feat-external-runtime-options

269fe35

Linchin reviewed Oct 1, 2025

View reviewed changes

Linchin self-requested a review October 1, 2025 21:33

Linchin previously approved these changes Oct 1, 2025

View reviewed changes

gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 2, 2025

Merge branch 'main' into feat-external-runtime-options

bf61066

chalmerlowe previously approved these changes Oct 13, 2025

View reviewed changes

chalmerlowe enabled auto-merge (squash) October 13, 2025 13:35

chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 13, 2025

yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 13, 2025

updates type hinting and formatting

73d6c71

chalmerlowe dismissed stale reviews from Linchin and themself via 73d6c71 October 14, 2025 11:20

chalmerlowe added 3 commits October 14, 2025 07:20

Merge branch 'main' into feat-external-runtime-options

067c33e

Merge branch 'main' into feat-external-runtime-options

6475428

updates type handling

340be1f

chalmerlowe added the automerge Merge the pull request once unit tests and other checks pass. label Oct 14, 2025

chalmerlowe approved these changes Oct 14, 2025

View reviewed changes

Linchin self-requested a review October 14, 2025 18:51

Linchin approved these changes Oct 14, 2025

View reviewed changes

chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 15, 2025

yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 15, 2025

chalmerlowe merged commit fa76e31 into main Oct 15, 2025
28 of 30 checks passed

chalmerlowe deleted the feat-external-runtime-options branch October 15, 2025 10:31

gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 15, 2025

release-please Bot mentioned this pull request Oct 14, 2025

chore(main): release 3.39.0 #2304

Closed

This was referenced Nov 7, 2025

chore: librarian release pull request: 20251107T182340Z #2327

Closed

chore: librarian release pull request: 20251107T183245Z #2328

Closed

gkevinzheng mentioned this pull request Nov 21, 2025

chore: librarian release pull request: 20251121T182406Z #2335

Closed

This was referenced Nov 21, 2025

chore: librarian release pull request: 20251121T143310Z #2336

Closed

chore: librarian release pull request: 20251121T143403Z #2337

Closed

chalmerlowe mentioned this pull request Dec 12, 2025

chore: librarian release pull request: 20251212T151524Z #2344

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add ExternalRuntimeOptions to BigQuery routine#2311

feat: Add ExternalRuntimeOptions to BigQuery routine#2311
chalmerlowe merged 14 commits intomainfrom
feat-external-runtime-options

google-labs-jules Bot commented Sep 29, 2025 •

edited by chalmerlowe

Loading

Uh oh!

google-labs-jules Bot commented Sep 29, 2025

Uh oh!

Uh oh!

chalmerlowe commented Sep 29, 2025

Uh oh!

google-labs-jules Bot commented Sep 29, 2025

Uh oh!

chalmerlowe commented Sep 29, 2025

Uh oh!

google-labs-jules Bot commented Sep 29, 2025

Uh oh!

Uh oh!

Linchin Oct 1, 2025

Uh oh!

Linchin left a comment

Uh oh!

gcf-merge-on-green Bot commented Oct 2, 2025

Uh oh!

chalmerlowe left a comment

Uh oh!

chalmerlowe left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

google-labs-jules Bot commented Sep 29, 2025 • edited by chalmerlowe Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-labs-jules Bot commented Sep 29, 2025

Uh oh!

Uh oh!

chalmerlowe commented Sep 29, 2025

Uh oh!

google-labs-jules Bot commented Sep 29, 2025

Uh oh!

chalmerlowe commented Sep 29, 2025

Uh oh!

google-labs-jules Bot commented Sep 29, 2025

Uh oh!

Uh oh!

Linchin Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Linchin left a comment

Choose a reason for hiding this comment

Uh oh!

gcf-merge-on-green Bot commented Oct 2, 2025

Uh oh!

chalmerlowe left a comment

Choose a reason for hiding this comment

Uh oh!

chalmerlowe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

google-labs-jules Bot commented Sep 29, 2025 •

edited by chalmerlowe

Loading