chore: librarian release pull request: 20260108T134327Z by daniel-sanche · Pull Request #883 · googleapis/python-api-core · GitHub
Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

chore: librarian release pull request: 20260108T134327Z#883

Merged
daniel-sanche merged 1 commit intomainfrom
librarian-20260108T134327Z
Jan 8, 2026
Merged

chore: librarian release pull request: 20260108T134327Z#883
daniel-sanche merged 1 commit intomainfrom
librarian-20260108T134327Z

Conversation

@daniel-sanche
Copy link
Copy Markdown
Contributor

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release.

Librarian Version: v1.0.1
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620

google-api-core: 2.29.0

2.29.0 (2026-01-08)

Features

Bug Fixes

@daniel-sanche daniel-sanche requested review from a team January 8, 2026 21:43
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Jan 8, 2026
@gemini-code-assist
Copy link
Copy Markdown

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is an automated release PR to bump the version of google-api-core to 2.29.0. The changes include updating the version in version.py and .librarian/state.yaml, and adding a new entry to CHANGELOG.md. My review focuses on the correctness of the generated changelog. I've found that the links in the new changelog entry are incorrect and inconsistent with previous entries, and I've provided a suggestion to fix them.

Comment thread CHANGELOG.md
Comment on lines +7 to +22
## [2.29.0](https://github.com/googleapis/google-cloud-python/compare/google-api-core-v2.28.1...google-api-core-v2.29.0) (2026-01-08)


### Features

* Auto enable mTLS when supported certificates are detected (#869) ([f8bf6f9610f3e0e7580f223794c3906513e1fa73](https://github.com/googleapis/google-cloud-python/commit/f8bf6f9610f3e0e7580f223794c3906513e1fa73))
* make parse_version_to_tuple public (#864) ([c969186f2b66bde1df5e25bbedc5868e27d136f9](https://github.com/googleapis/google-cloud-python/commit/c969186f2b66bde1df5e25bbedc5868e27d136f9))


### Bug Fixes

* flaky tests due to imprecision in floating point calculation and performance test setup (#865) ([93404080f853699b9217e4b76391a13525db4e3e](https://github.com/googleapis/google-cloud-python/commit/93404080f853699b9217e4b76391a13525db4e3e))
* remove call to importlib.metadata.packages_distributions() for py38/py39 (#859) ([628003e217d9a881d24f3316aecfd48c244a73f0](https://github.com/googleapis/google-cloud-python/commit/628003e217d9a881d24f3316aecfd48c244a73f0))
* Log version check errors (#858) ([6493118cae2720696c3d0097274edfd7fe2bce67](https://github.com/googleapis/google-cloud-python/commit/6493118cae2720696c3d0097274edfd7fe2bce67))
* closes tailing streams in bidi classes. (#851) ([c97b3a004044ebf8b35c2a7ba97409d7795e11b0](https://github.com/googleapis/google-cloud-python/commit/c97b3a004044ebf8b35c2a7ba97409d7795e11b0))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The links in this changelog entry appear to be incorrect. They point to the google-cloud-python repository instead of python-api-core. Additionally, the format of the links is inconsistent with previous entries:

  • The version comparison link incorrectly prefixes tags with google-api-core-.
  • The commit SHAs in the link text are full-length instead of the conventional short format.

For consistency and correctness, please update the links.

Suggested change

@daniel-sanche daniel-sanche enabled auto-merge (squash) January 8, 2026 21:48
@daniel-sanche daniel-sanche merged commit 014d3de into main Jan 8, 2026
20 of 21 checks passed
@daniel-sanche daniel-sanche deleted the librarian-20260108T134327Z branch January 8, 2026 21:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release:done size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants