{{ message }}
This repository was archived by the owner on Mar 23, 2026. It is now read-only.
fix(test): Update schema for broken ConnImplBenchmark test#3574
Merged
Conversation
product-auto-label
Bot
added
the
api: bigquery
o-shevchenko
changed the title
Contributor
Author
|
@alvarowolfx Could you please help with the review and performance evaluation? |
Contributor
Author
|
@alvarowolfx, did you have a chance to look into it? |
|
@PhongChuong can you take a look on this one ? |
PhongChuong
approved these changes
Dec 2, 2024
PhongChuong
left a comment
PhongChuong
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix.
Lets discuss the slow read results in further in #2764.
Contributor
|
/gcbrun |
Contributor
Author
PhongChuong
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
This was referenced Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to use the
executeSelectAPI and faced extremely slow reading.I tried to use
ConnImplBenchmarkbut noticed that the Shema was changed, and the test didn't work.bigquery-public-data.new_york_taxi_trips.tlc_yellow_trips_2017Summary of Changes
Added Fields: airport_fee, data_file_year, data_file_month.
Removed Fields: dropoff_longitude, dropoff_latitude, pickup_longitude, pickup_latitude.
After fixing the test I can confirm that we have similar speed results for our use cases.
Reading 100_000 rows takes ~15-20 seconds, which is extremely slow.
I'm not sure if there was any performance degradation recently since I can't find any expected numbers. It's hard to read this benchmark: https://cloud.google.com/blog/topics/developers-practitioners/introducing-executeselect-client-library-method-and-how-use-it/
According to this image, reading of 1_000_000 rows should take ~1sec
That's what I've got on my machine:
I've opened an issue: googleapis/java-bigquerystorage#2764