Removing projection=full from Blob/Bucket PATCH requests. by dhermes · Pull Request #758 · googleapis/google-cloud-python · GitHub
Skip to content

Removing projection=full from Blob/Bucket PATCH requests.#758

Closed
dhermes wants to merge 1 commit intogoogleapis:masterfrom
dhermes:ditch-full-projection-in-patch
Closed

Removing projection=full from Blob/Bucket PATCH requests.#758
dhermes wants to merge 1 commit intogoogleapis:masterfrom
dhermes:ditch-full-projection-in-patch

Conversation

@dhermes
Copy link
Copy Markdown
Contributor

@dhermes dhermes commented Mar 25, 2015

There was a previous comment

Pass ?projection=full here because PATCH documented not to work properly w/ noAcl.

I tested a little with this and it doesn't seem to be an issue.

@thobrla Can you confirm or deny any issues with projection=full?

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 25, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2015
@thobrla
Copy link
Copy Markdown

thobrla commented Mar 25, 2015

@dhermes
Copy link
Copy Markdown
Contributor Author

dhermes commented Mar 25, 2015

RE: "is there a reason to specify noAcl" That is a discussion in flux. Currently ACL behavior is managed via dedicated objects instead of directly with the Blob or Bucket. (UPDATE: I don't think this is necessarily the right abstraction, but am in the process of making "interface drive design" document to discuss.)

RE: "won't return the acl to you unless you have OWNER permission" I would wager that was the original author's concern. Thanks!

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 25, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 853d240 on dhermes:ditch-full-projection-in-patch into d34a15e on GoogleCloudPlatform:master.

@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Mar 26, 2015

The API docs say:

projection  string  Set of properties to return. Defaults to no_acl.

Note: Currently only works if you override the default and specify full.

Acceptable values are:

    "full": Include all properties.
    "noAcl": Omit acl and defaultObjectAcl properties.

@dhermes
Copy link
Copy Markdown
Contributor Author

dhermes commented Mar 26, 2015

@tseaver Thanks for pointing this out. @thobrla is that still true? When was it true? "only works" is somewhat vague as it is.

@Capstan
Copy link
Copy Markdown

Capstan commented Mar 27, 2015

@dhermes It has to do with the way that patch currently is implemented. I suspect that if you had custom ACLs on your bucket that if you patch with no_acl, you inadvertently reset your bucket ACL to project-private.

@dhermes
Copy link
Copy Markdown
Contributor Author

dhermes commented Mar 28, 2015

I see.

  • Do you mean sending a patch with an empty list in the acl field or none at all? (ISTM you're describing a process where a GET is performed internally with noAcl and then the contents are updated based on the PATCH contents, and then this just gets inserted directly.)
  • Are there plans to fix / address / document this behavior?
  • Is there a corresponding issue with objects or is it limited to buckets?

@dhermes dhermes added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 30, 2015
@dhermes
Copy link
Copy Markdown
Contributor Author

dhermes commented Mar 30, 2015

Adding the don't merge label. It seems from @Capstan feedback (and just from designing the optimal interface in #761) that projection=noAcl isn't something we need. Splitting apart ACLs from other properties isn't worth the payload size savings (1KB to 2KB).

@dhermes dhermes mentioned this pull request Jun 25, 2015
Merged
@lukesneeringer
Copy link
Copy Markdown
Contributor

lukesneeringer commented Mar 16, 2017

@dhermes dhermes deleted the ditch-full-projection-in-patch branch March 16, 2017 23:01
parthea pushed a commit that referenced this pull request Aug 21, 2025
@gcf-owl-bot
chore(python): update dependencies in /.kokoro (#758)
ad50b62 
Source-Link: googleapis/synthtool@db94845
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a8a80fc6456e433df53fc2a0d72ca0345db0ddefb409f1b75b118dfd1babd952

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
@gcf-owl-bot @parthea
chore(python): update dependencies in /.kokoro (#758)
f6d0d94 
Source-Link: googleapis/synthtool@db94845
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a8a80fc6456e433df53fc2a0d72ca0345db0ddefb409f1b75b118dfd1babd952

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@renovate-bot
chore(deps): update dependency jinja2 to v2.11.3 (#758)
62d9814 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jinja2](https://palletsprojects.com/p/jinja/) ([source](https://togithub.com/pallets/jinja)) | `==2.11.2` -> `==2.11.3` | [![age](https://badges.renovateapi.com/packages/pypi/jinja2/2.11.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/jinja2/2.11.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/jinja2/2.11.3/compatibility-slim/2.11.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/jinja2/2.11.3/confidence-slim/2.11.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>pallets/jinja</summary>

### [`v2.11.3`](https://togithub.com/pallets/jinja/blob/master/CHANGES.rst#Version-2113)

[Compare Source](https://togithub.com/pallets/jinja/compare/2.11.2...2.11.3)

Released 2021-01-31

-   Improve the speed of the `urlize` filter by reducing regex
    backtracking. Email matching requires a word character at the start
    of the domain part, and only word characters in the TLD. :pr:`1343`

</details>

---

### Renovate configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻️ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-python).
parthea pushed a commit that referenced this pull request Nov 24, 2025
@davidwtbuxton
fix: Handle exceptions raised when fetching Django request data (#758)
7025dd6
parthea pushed a commit that referenced this pull request Nov 25, 2025
@davidwtbuxton
fix: Handle exceptions raised when fetching Django request data (#758)
39bfd15
parthea pushed a commit that referenced this pull request Mar 6, 2026
@plamut
feat: add support for more detailed DML stats (#758)
41b43ef 
* feat: add support for more detailed DML stats

* Move is None check of DmlStats one level higher
parthea pushed a commit that referenced this pull request Mar 6, 2026
@release-please
chore: release 2.22.0 (#771)
ff79006 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.22.0](https://www.github.com/googleapis/python-bigquery/compare/v2.21.0...v2.22.0) (2021-07-19)


### Features

* add `LoadJobConfig.projection_fields` to select DATASTORE_BACKUP fields ([#736](https://www.github.com/googleapis/python-bigquery/issues/736)) ([c45a738](https://www.github.com/googleapis/python-bigquery/commit/c45a7380871af3dfbd3c45524cb606c60e1a01d1))
* add standard sql table type, update scalar type enums ([#777](https://www.github.com/googleapis/python-bigquery/issues/777)) ([b8b5433](https://www.github.com/googleapis/python-bigquery/commit/b8b5433898ec881f8da1303614780a660d94733a))
* add support for more detailed DML stats ([#758](https://www.github.com/googleapis/python-bigquery/issues/758)) ([36fe86f](https://www.github.com/googleapis/python-bigquery/commit/36fe86f41c1a8f46167284f752a6d6bbf886a04b))
* add support for user defined Table View Functions ([#724](https://www.github.com/googleapis/python-bigquery/issues/724)) ([8c7b839](https://www.github.com/googleapis/python-bigquery/commit/8c7b839a6ac1491c1c3b6b0e8755f4b70ed72ee3))


### Bug Fixes

* avoid possible job already exists error ([#751](https://www.github.com/googleapis/python-bigquery/issues/751)) ([45b9308](https://www.github.com/googleapis/python-bigquery/commit/45b93089f5398740413104285cc8acfd5ebc9c08))


### Dependencies

* allow 2.x versions of `google-api-core`, `google-cloud-core`, `google-resumable-media` ([#770](https://www.github.com/googleapis/python-bigquery/issues/770)) ([87a09fa](https://www.github.com/googleapis/python-bigquery/commit/87a09fa3f2a9ab35728a1ac925f9d5f2e6616c65))


### Documentation

* add loading data from Firestore backup sample ([#737](https://www.github.com/googleapis/python-bigquery/issues/737)) ([22fd848](https://www.github.com/googleapis/python-bigquery/commit/22fd848cae4af1148040e1faa31dd15a4d674687))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Mar 6, 2026
@vi3k6i5
docs: Add limitations docs on spanner features not supported by spann…
d291ad4 
…er-django library. (#758)

* chore: release 2.2.1b4

Release-As: 2.2.1b4

* docs: Add spanner django limitations from spanner perspective

* docs: refactored table layout for workarounds in spanner limitations files

* refactor: remove double occurance of work workaround in spanner limitations file
parthea pushed a commit that referenced this pull request Mar 9, 2026
@renovate-bot
chore(deps): update dependency grpcio-status to v1.75.1 (#758)
46f2bb0
parthea pushed a commit that referenced this pull request Mar 9, 2026
@renovate-bot
chore(deps): update dependency google-cloud-pubsub to v2.12.0 (#758)
56af7e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@dhermes @thobrla @coveralls @tseaver @Capstan @lukesneeringer @danoscarmike @googlebot