{{ message }}
Add Part Of Speech missing data to Token#3457
Merged
tseaver merged 11 commits intogoogleapis:masterfrom Jun 5, 2017
Merged
Conversation
googlebot
added
the
cla: no
Contributor
Author
|
I signed it! |
|
CLAs look good, thanks! |
googlebot
added
cla: yes
added 8 commits
May 29, 2017 16:39
lukesneeringer
approved these changes
May 30, 2017
Contributor
lukesneeringer
left a comment
lukesneeringer
left a comment
There was a problem hiding this comment.
This looks good to me. (Thanks for all your work, @dvaldivia!)
Contributor
Author
|
@lukesneeringer you are welcome :) What's next? Do I need to do anything else? |
dhermes
reviewed
May 31, 2017
| class PartOfSpeech(object): | ||
| """Part of speech of a :class:`Token`.""" | ||
| """A Google Cloud Natural Language API Part of speech object. | ||
| Rich data about the Part of Speech of a token returned by the API |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
reviewed
May 31, 2017
|
|
||
| from copy import copy | ||
| import unittest | ||
| from copy import copy |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
tseaver
added
the
api: language
This was referenced Jun 26, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
Add support for all the data returned by the API for PartOfSpeech inside Token.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
Add support for all the data returned by the API for PartOfSpeech inside Token.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
Add support for all the data returned by the API for PartOfSpeech inside Token.
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
Add support for all the data returned by the API for PartOfSpeech inside Token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR add the missing data returned by the API to the Token, before only the Tag was being returned, I added all the data to the existing PartOfSpeech object and replaced it's hydratation on the Token as well