Prepare 0.18.0 release. by tseaver · Pull Request #2048 · googleapis/google-cloud-python · GitHub
Skip to content

Prepare 0.18.0 release.#2048

Merged
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:0.18.0-release
Aug 3, 2016
Merged

Prepare 0.18.0 release.#2048
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:0.18.0-release

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented Aug 3, 2016

(redone from #2044)

$ git log -1 --pretty=%H
2724805
[/home/tseaver/projects/agendaless/Google/src/gcloud-python]
$ git log 0.17.0..HEAD | grep 'Merge pull request ' | awk -F ' ' '{print $4}' | sort
#1636
#1775
#1832
#1833
#1836
#1876
#1914
#1943
#1945
#1946
#1948
#1950
#1952
#1954
#1956
#1958
#1962
#1965
#1966
#1967
#1971
#1973
#1974
#1976
#1977
#1985
#1990
#1992
#1994
#1996
#1997
#1999
#2000
#2002
#2003
#2004
#2005
#2006
#2008
#2016
#2019
#2021
#2025
#2026
#2029
#2033
#2036
#2040
#2041

#3 stray comment from #1914

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2016
@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Aug 3, 2016

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Aug 3, 2016

@daspecster, @dhermes: Redone without the Github-UI-induced weirdness (and squashed). PTAL

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Aug 3, 2016

LGTM.

nit: In the release notes, why have an empty line between every bullet?

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Aug 3, 2016

@dhermes because markdown suckspenalizes the rendered form for improved readability in the source.

@tseaver tseaver merged commit 891e4a8 into googleapis:master Aug 3, 2016
@tseaver tseaver deleted the 0.18.0-release branch August 3, 2016 17:56
@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Aug 3, 2016

Does not compute. What do you mean? What is the readability penalty?

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Aug 3, 2016

Its twofold: it treats all newlines as paragraphs, which makes editing paragraphs harder. And in the source form, bullet lists are easier to read with a line between each item, particularly where items might be longer than a single line.

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Aug 3, 2016

And in the source form, bullet lists are easier to read with a line between each item

That's subjective. No worries though, I don't have any strong preference.

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Aug 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants