feat(bigquery-magics): drop support for Python 3.9 by tswast · Pull Request #16587 · googleapis/google-cloud-python · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/bigquery-magics/noxfile.py
10 changes: 5 additions & 5 deletions packages/bigquery-magics/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,17 @@
# 'Development Status :: 5 - Production/Stable'``
release_status = "Development Status :: 4 - Beta"
dependencies = [
"db-dtypes>=0.3.0,<2.0.0",
"db-dtypes>=1.1.1,<2.0.0",
"google-cloud-bigquery >= 3.13.0, <4.0.0",
"ipywidgets>=7.7.1",
"ipython>=7.23.1",
"ipykernel>=5.5.6",
"packaging >= 20.0.0",
"pandas>=1.2.0",
"pyarrow >= 3.0.0",
"pandas>=1.5.3",
"pyarrow >= 12.0.0",
"pydata-google-auth >=1.5.0",
"tqdm >= 4.7.4, <5.0.0",
"pyopenssl >= 23.3.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding pyopenssl as a mandatory dependency is a significant change, as it requires C extensions and is generally not needed for Python 3.10+. Could you explain why this is now required for all users? If it's only needed for specific edge cases, consider making it an optional extra.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several unit tests fail without this change. Note that it is a required dependency in later versions of google-auth, anyway.

]
extras = {
# bqstorage had a period where it was a required dependency, and has been
Expand Down Expand Up @@ -106,7 +107,6 @@
"License :: OSI Approved :: Apache Software License",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Expand All @@ -119,7 +119,7 @@
packages=packages,
install_requires=dependencies,
extras_require=extras,
python_requires=">=3.9",
python_requires=">=3.10",
include_package_data=True,
zip_safe=False,
)
27 changes: 21 additions & 6 deletions packages/bigquery-magics/testing/constraints-3.10.txt
18 changes: 0 additions & 18 deletions packages/bigquery-magics/testing/constraints-3.9.txt

This file was deleted.

Loading