chore(librarian): update synthtool SHA by parthea · Pull Request #16171 · googleapis/google-cloud-python · GitHub
Skip to content

chore(librarian): update synthtool SHA#16171

Merged
parthea merged 1 commit into
mainfrom
parthea-patch-11
Mar 25, 2026
Merged

chore(librarian): update synthtool SHA#16171
parthea merged 1 commit into
mainfrom
parthea-patch-11

Conversation

@parthea

@parthea parthea commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

The source of truth for the "generated" README for client libraries currently lives at https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/python_mono_repo_library/README.rst

We recently dropped Python 3.7 and 3.8 in #16150 and #16102.

The supported Python runtimes was recently updated to reflect this change in googleapis/synthtool#2168 (commit googleapis/synthtool@96f416c).

We need to update the synthtool commit in the python librarian Dockerfile to include the new README.

@parthea parthea requested review from a team as code owners March 25, 2026 20:22
@gemini-code-assist

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the synthtool git commit hash in the .generator/Dockerfile. The reviewer suggests adding a comment to explain the reason for checking out this specific commit to improve maintainability and provide context for future updates.

Comment thread .generator/Dockerfile

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, consider adding a comment to explain why this specific commit is being checked out. This provides valuable context for future updates.

    git checkout 96f416c959fbe8048200b6c16000de32b352902e # Update supported Python versions in README template

@parthea parthea merged commit 9b893ff into main Mar 25, 2026
29 checks passed
@parthea parthea deleted the parthea-patch-11 branch March 25, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants