{{ message }}
fix: fix mypy errors in google-cloud-monitoring-dashboards/google/monitoring#15493
Merged
Conversation
Contributor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively resolves a number of mypy errors, primarily related to the strict no_implicit_optional setting. The changes are well-executed and improve the overall type safety and correctness of the codebase. Key fixes include explicitly using Optional for parameters that can be None, correcting invalid type assignments, fixing docstring inaccuracies, and removing obsolete files that were causing build failures. The code is now cleaner and more robust against type-related issues.
ohmayr
pushed a commit
that referenced
this pull request
Feb 5, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.0.0-20251218164811-cd2252e38d0a Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:d3ae275c61acca91e1398581edfb9119c521b4e93f9ebb00ecbd4e87b71648f5 <details><summary>google-ads-datamanager: 0.4.0</summary> ## [0.4.0](google-ads-datamanager-v0.3.0...google-ads-datamanager-v0.4.0) (2026-02-05) ### Bug Fixes * update `go_package` packaging option from `google.golang.org/genproto/googleapis/ads/datamanager/v1;datamanager` to `cloud.google.com/go/datamanager/apiv1/datamanagerpb;datamanagerpb` (PiperOrigin-RevId: 863287879) ([fe0a0b4](fe0a0b46)) ### Documentation * describe additional URI format for kek_uri in GcpEncryptionInfo and AwsKmsEncryptionInfo (PiperOrigin-RevId: 863287879) ([fe0a0b4](fe0a0b46)) </details> <details><summary>google-apps-card: 0.5.0</summary> ## [0.5.0](google-apps-card-v0.4.0...google-apps-card-v0.5.0) (2026-02-05) ### Documentation * update reference documentation for `SelectionInput.DROPDOWN` to include dynamic data sources and autosuggestion (PiperOrigin-RevId: 864941572) ([fe0a0b4](fe0a0b46)) * update copyright to 2026 (PiperOrigin-RevId: 864941572) ([fe0a0b4](fe0a0b46)) </details> <details><summary>google-apps-chat: 0.6.0</summary> ## [0.6.0](google-apps-chat-v0.5.0...google-apps-chat-v0.6.0) (2026-02-05) ### Features * Addition of QuoteType enum, QuotedMessageSnapshot &amp; ForwardMetadata in the QuotedMessageMetadata proto (PiperOrigin-RevId: 864426372) ([fe0a0b4](fe0a0b46)) </details> <details><summary>google-cloud-apiregistry: 0.1.0</summary> ## [0.1.0](google-cloud-apiregistry-v0.0.0...google-cloud-apiregistry-v0.1.0) (2026-02-05) ### Features * onboard a new library (PiperOrigin-RevId: 848064295) ([6837229](68372299)) </details> <details><summary>google-cloud-auditmanager: 0.1.0</summary> ## [0.1.0](google-cloud-auditmanager-v0.0.0...google-cloud-auditmanager-v0.1.0) (2026-02-05) ### Features * generate libraries (#15502) (PiperOrigin-RevId: 861758611) ([4997475](4997475a)) </details> <details><summary>google-cloud-backupdr: 0.8.0</summary> ## [0.8.0](google-cloud-backupdr-v0.7.0...google-cloud-backupdr-v0.8.0) (2026-02-05) ### Features * Add support for AlloyDB backup and restore (PiperOrigin-RevId: 862089230) ([fe0a0b4](fe0a0b46)) ### Documentation * A comment for field `log_retention_days` in message `.google.cloud.backupdr.v1.BackupPlan` is changed (PiperOrigin-RevId: 862089230) ([fe0a0b4](fe0a0b46)) </details> <details><summary>google-cloud-monitoring: 2.29.1</summary> ## [2.29.1](google-cloud-monitoring-v2.29.0...google-cloud-monitoring-v2.29.1) (2026-02-05) ### Bug Fixes * fix mypy errors (#15494) ([1f4c286](1f4c2862)) </details> <details><summary>google-cloud-monitoring-dashboards: 2.20.1</summary> ## [2.20.1](google-cloud-monitoring-dashboards-v2.20.0...google-cloud-monitoring-dashboards-v2.20.1) (2026-02-05) ### Bug Fixes * fix mypy errors in google-cloud-monitoring-dashboards/google/monitoring (#15493) ([ca15a7e](ca15a7e6)) </details> <details><summary>google-cloud-org-policy: 1.16.1</summary> ## [1.16.1](google-cloud-org-policy-v1.16.0...google-cloud-org-policy-v1.16.1) (2026-02-05) ### Bug Fixes * fix mypy errors (#15494) ([1f4c286](1f4c2862)) </details> <details><summary>google-cloud-quotas: 0.5.0</summary> ## [0.5.0](google-cloud-quotas-v0.4.0...google-cloud-quotas-v0.5.0) (2026-02-05) ### Features * Hierarchical Quota Adjuster (PiperOrigin-RevId: 863242165) ([fe0a0b4](fe0a0b46)) ### Documentation * Folder level and organization level support for the quota adjuster feature. (PiperOrigin-RevId: 863242165) ([fe0a0b4](fe0a0b46)) </details> <details><summary>google-cloud-speech: 2.36.1</summary> ## [2.36.1](google-cloud-speech-v2.36.0...google-cloud-speech-v2.36.1) (2026-02-05) ### Bug Fixes * fix mypy errors (#15494) ([1f4c286](1f4c2862)) </details> <details><summary>google-cloud-vectorsearch: 0.4.0</summary> ## [0.4.0](google-cloud-vectorsearch-v0.3.0...google-cloud-vectorsearch-v0.4.0) (2026-02-05) ### Features * Allow requesting search metadata in SearchDataObjects (PiperOrigin-RevId: 863352956) ([fe0a0b4](fe0a0b46)) * add filter param for TextSearch requests (PiperOrigin-RevId: 863352956) ([fe0a0b4](fe0a0b46)) * add SearchHint to SemanticSearch requests (PiperOrigin-RevId: 863352956) ([fe0a0b4](fe0a0b46)) * add ExportDataObjects API (PiperOrigin-RevId: 863352956) ([fe0a0b4](fe0a0b46)) </details> <details><summary>google-cloud-vision: 3.12.1</summary> ## [3.12.1](google-cloud-vision-v3.12.0...google-cloud-vision-v3.12.1) (2026-02-05) ### Bug Fixes * fix mypy errors (#15494) ([1f4c286](1f4c2862)) </details> <details><summary>grafeas: 1.19.1</summary> ## [1.19.1](grafeas-v1.19.0...grafeas-v1.19.1) (2026-02-05) ### Bug Fixes * fix mypy (#15496) ([4daf9cc](4daf9cc2)) </details> <details><summary>Bulk Changes</summary> * chore: librarian update image pull request: 20260123T001116Z (#15481) ([871cdee](871cdeeb)) Libraries: google-ads-datamanager,google-apps-card,google-apps-chat,google-cloud-backupdr,google-cloud-monitoring,google-cloud-monitoring-dashboards,google-cloud-org-policy,google-cloud-speech,google-cloud-vectorsearch,google-cloud-vision </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #15104
This is needed to unblock #15457 . See the following mypy failure for
google-cloud-monitoring-dashboardsSee follow up issue #11858 to remove the
google/monitoringfolder which is no longer being generated automatically.See follow up issue googleapis/proto-plus-python#558 for the
prereleasepresubmit failure.