Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 458
chore: Add the PQC conformance tests #9299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Hectorhammett
wants to merge
1
commit into
main
Choose a base branch
from
pqc-preparation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| <?php | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Google\Generator\Tests\Conformance; | ||
|
|
||
| use Google\ApiCore\InsecureCredentialsWrapper; | ||
| use Google\ApiCore\RequestBuilder; | ||
| use Google\ApiCore\Transport\GrpcTransport; | ||
| use Google\ApiCore\Transport\RestTransport; | ||
| use Google\ApiCore\Transport\TransportInterface; | ||
| use Google\Auth\HttpHandler\HttpHandlerFactory; | ||
| use Google\Showcase\V1beta1\Client\EchoClient; | ||
| use Google\Showcase\V1beta1\EchoRequest; | ||
| use Grpc\ChannelCredentials; | ||
| use GuzzleHttp\Client; | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class PqcShowcaseTest extends TestCase | ||
| { | ||
| private const TLS_GROUP = 'x-showcase-tls-group'; | ||
| private const TLS_VERSION = 'x-showcase-tls-version'; | ||
|
|
||
| public function provideTransport(): array | ||
| { | ||
| $pemPath = __DIR__ . '/showcase.pem'; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. missing file?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is autogenerated by the showcase server when started. |
||
| $host = 'localhost:7469'; | ||
|
|
||
| // gRPC Configuration | ||
| $pemContents = file_get_contents($pemPath); | ||
| if (!$pemContents) { | ||
| $this->fail('Could not read showcase.pem'); | ||
| } | ||
|
|
||
| $grpcTransport = GrpcTransport::build($host, [ | ||
| 'stubOpts' => [ | ||
| 'credentials' => ChannelCredentials::createSsl($pemContents) | ||
| ] | ||
| ]); | ||
|
|
||
| // REST Configuration | ||
| $restConfigPath = __DIR__ . '/src/V1beta1/resources/echo_rest_client_config.php'; | ||
|
|
||
| $requestBuilder = new RequestBuilder($host, $restConfigPath); | ||
| $guzzleClient = new Client([ | ||
| 'verify' => $pemPath | ||
| ]); | ||
| $httpHandler = HttpHandlerFactory::build($guzzleClient); | ||
| $restTransport = new RestTransport($requestBuilder, [$httpHandler, 'async']); | ||
|
|
||
| return [[$grpcTransport], [$restTransport]]; | ||
| } | ||
|
|
||
| /** @dataProvider provideTransport */ | ||
| public function testPqc(TransportInterface $transport): void | ||
| { | ||
| $expected = 'This is a test'; | ||
| $expectedGroup = 'X25519MLKEM768'; | ||
| $expectedVersion = 'TLS 1.3'; | ||
| $responseHeaders = null; | ||
| $metadataCallback = function (array $metadata) use (&$responseHeaders) { | ||
| $responseHeaders = $metadata; | ||
| }; | ||
|
|
||
| $echoClient = new EchoClient([ | ||
| 'credentials' => new InsecureCredentialsWrapper(), | ||
| 'transport' => $transport | ||
| ]); | ||
|
|
||
| $echoRequest = new EchoRequest(); | ||
| $echoRequest->setContent($expected); | ||
| $response = $echoClient->echo($echoRequest, [ | ||
| 'metadataCallback' => $metadataCallback | ||
| ]); | ||
|
|
||
| $this->assertEquals($expected, $response->getContent()); | ||
| $this->assertNotNull($responseHeaders); | ||
|
|
||
| /** @var array<string, array<int, string>> $responseHeaders */ | ||
| $responseHeaders = array_change_key_case($responseHeaders, CASE_LOWER); | ||
|
|
||
| $this->assertEquals($expectedVersion, $responseHeaders[self::TLS_VERSION][0]); | ||
| $this->assertEquals($expectedGroup, $responseHeaders[self::TLS_GROUP][0]); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You upgraded the showcase version but then removed the lines using it? I assume these will be added back once the
feat-pqc-tlsbranch is merged and tagged?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope so, this is for now as it is what it "works". If it gets merged and tagged, we are updatting this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit confused, we did not removed the lines using it, is under the next step:
Run the GAPIC showcase server