{{ message }}
Repository navigation
feat(gax): emit T4 attempt spans #9496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,966
−356
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
440c2ce
feat(gax): inject active OpenTelemetry span context into gRPC and HTT…
shivanee-p 998dc2c
docs(gax): remove instrumentation library setup from observability sa…
shivanee-p 7cad06f
style(gax): fix prettier formatting in timeout, util, and unit tests
shivanee-p 8577f00
fix(gax): clone plain object metadata before injecting span context
shivanee-p 8e7e676
refactor(gax): move OpenTelemetry context propagation into TracerHelp…
shivanee-p ad27eba
fix(gax): resolve TypeScript narrowing error in metadataPropagation test
shivanee-p ce310fa
feat(gax): emit T4 per-attempt client spans directly without instrume…
shivanee-p c460b33
feat(gax): add resend_count to T4 spans and consolidate T4 unit tests
shivanee-p 396dcd0
feat(gax): refine T3 and T4 span method, status code, and client attr…
shivanee-p 0a1dd07
refactor(gax): narrow dynamicArgs and staticArgs before calling trace…
shivanee-p 0c600fa
docs(gax): add concise comments to traceAttempt and createApiCall
shivanee-p 41949c4
feat(gax): set url.domain on T3 spans
shivanee-p 2707dac
Wrap function call to avoid variable mutation and memory leaks
shivanee-p dd3f236
refactor(gax): remove type assertions from attempt tracing wrapper in…
shivanee-p 1fb3fac
fix: remove gcp.client.service attribute from tracer initial attributes
shivanee-p df61886
docs(gax): replace internal T3 and T4 tracing terms with client reque…
shivanee-p 726eec4
fix(gax): do not increment resend_count on paginated page requests
shivanee-p 3142302
style(gax): fix prettier formatting in apiCallable tests
shivanee-p bb837ee
fix(gax): update HTTP attempt span naming, set status.message on erro…
shivanee-p 0d99934
fix(gax): wire matched url.template from REST transcoding into HTTP a…
shivanee-p f0845f0
fix(gax): preserve transcode call in fallbackRest for regapic spy com…
shivanee-p b338db3
feat(gax): set status.message attribute on T3 spans when an error occurs
shivanee-p 27eb0e3
feat(gax): set rpc.method on T3 spans from the last T4 child span
shivanee-p File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.

Uh oh!
There was an error while loading. Please reload this page.