iframe-proxy

mderka · 2016-04-08T21:12:11Z

I added a parameter in the retry helper method which indicates whether retries should be attempted on timeouts. The default value is true.

I considered adding this to retryParams, but I concluded that this is related to the nature of the operation where the retry helper is being used and not to the the configuration itself. Therefore, I chose this solution using an extra parameter.

I adjusted DNS accordingly. Other services can follow.

This fixes #816 and #808.

coveralls · 2016-04-08T21:18:22Z

Sign in to view

 import org.junit.Before;
 import org.junit.Test;

+import java.net.SocketTimeoutException;


mderka · 2016-04-08T21:27:59Z

PTAL. I squashed the commit.

coveralls · 2016-04-08T21:34:16Z

Coverage increased (+0.001%) to 85.599% when pulling 0bdf0ed on mderka:retryhelper into 1eb3522 on GoogleCloudPlatform:master.

This fixes googleapis#816 and googleapis#808.

coveralls · 2016-04-08T21:55:39Z

Coverage increased (+0.01%) to 85.609% when pulling 03e1eaf on mderka:retryhelper into 1eb3522 on GoogleCloudPlatform:master.

mderka · 2016-04-08T22:52:44Z

@aozarov is suggesting a different solution. Please, put reviewing this one on hold @mziccard.

aozarov · 2016-04-09T18:09:41Z

🤖 I have created a release *beep* *boop* --- ## [0.123.3](googleapis/java-errorreporting@v0.123.2...v0.123.3) (2022-06-23) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#882](googleapis/java-errorreporting#882)) ([b0956b6](googleapis/java-errorreporting@b0956b6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@18d4e9b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f8374176dc59291f05dd3fec927a9da2cda687a9ef4de32e77f699a2be12ab45

…882) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `25.3.0` -> `26.0.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.0.0/compatibility-slim/25.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.0.0/confidence-slim/25.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-monitoring).

🤖 I have created a release *beep* *boop* --- ## [2.9.0](googleapis/java-securitycenter@v2.8.0...v2.9.0) (2022-08-06) ### Features * Added container field to findings attributes ([#875](googleapis/java-securitycenter#875)) ([d9b8007](googleapis/java-securitycenter@d9b8007)) ### Dependencies * update dependency com.google.cloud:google-cloud-bigquery to v2.14.0 ([#878](googleapis/java-securitycenter#878)) ([4c80791](googleapis/java-securitycenter@4c80791)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.1 ([#881](googleapis/java-securitycenter#881)) ([c7c68d3](googleapis/java-securitycenter@c7c68d3)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.2 ([#888](googleapis/java-securitycenter#888)) ([e786c87](googleapis/java-securitycenter@e786c87)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.3 ([#889](googleapis/java-securitycenter#889)) ([9a1437b](googleapis/java-securitycenter@9a1437b)) * update dependency com.google.cloud:google-cloud-pubsub to v1.120.10 ([#887](googleapis/java-securitycenter#887)) ([d5e013b](googleapis/java-securitycenter@d5e013b)) * update dependency com.google.cloud:google-cloud-pubsub to v1.120.7 ([#884](googleapis/java-securitycenter#884)) ([8392fb7](googleapis/java-securitycenter@8392fb7)) * update dependency com.google.cloud:google-cloud-pubsub to v1.120.9 ([#886](googleapis/java-securitycenter#886)) ([6db2c64](googleapis/java-securitycenter@6db2c64)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#882](googleapis/java-securitycenter#882)) ([43d2ca4](googleapis/java-securitycenter@43d2ca4)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.3 ([#877](googleapis/java-securitycenter#877)) ([b02a0d0](googleapis/java-securitycenter@b02a0d0)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.4 ([#880](googleapis/java-securitycenter#880)) ([9373129](googleapis/java-securitycenter@9373129)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [3.0.7](googleapis/java-recaptchaenterprise@v3.0.6...v3.0.7) (2022-09-08) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#882](googleapis/java-recaptchaenterprise#882)) ([26e9931](googleapis/java-recaptchaenterprise@26e9931)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.7.0](googleapis/java-document-ai@v2.6.2...v2.7.0) (2022-09-16) ### Features * Added Barcode support ([0ba37e1](googleapis/java-document-ai@0ba37e1)) * Added corrected_key_text, correct_value_text to FormField object in document.proto ([0ba37e1](googleapis/java-document-ai@0ba37e1)) * Added field_mask to ProcessRequest object in document_processor_service.proto ([0ba37e1](googleapis/java-document-ai@0ba37e1)) * Added integer_values, float_values and non_present to Entity object in document.proto ([0ba37e1](googleapis/java-document-ai@0ba37e1)) * Added OperationMetadata resource ([0ba37e1](googleapis/java-document-ai@0ba37e1)) * Added parent_ids to Revision object in document.proto ([0ba37e1](googleapis/java-document-ai@0ba37e1)) * Added Processor Management and Processor Version support to v1 library ([0ba37e1](googleapis/java-document-ai@0ba37e1)) ### Dependencies * Update dependency com.google.api.grpc:grpc-google-common-protos to v2.9.2 ([#876](googleapis/java-document-ai#876)) ([0d6068d](googleapis/java-document-ai@0d6068d)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#881](googleapis/java-document-ai#881)) ([29da839](googleapis/java-document-ai@29da839)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#882](googleapis/java-document-ai#882)) ([9a6c73c](googleapis/java-document-ai@9a6c73c)) * Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#867](googleapis/java-document-ai#867)) ([9772dc2](googleapis/java-document-ai@9772dc2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.3.10](https://togithub.com/googleapis/java-secretmanager/compare/v2.3.9...v2.3.10) (2022-10-05) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#881](https://togithub.com/googleapis/java-secretmanager/issues/881)) ([b275821](https://togithub.com/googleapis/java-secretmanager/commit/b2758216e91c385958942a124f31e3776c6f61c1)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.8.4](googleapis/java-core@v2.8.3...v2.8.4) (2022-07-27) ### Documentation * update javadocs for ReadChannel#limit to be more clear ([#880](googleapis/java-core#880)) ([942e8cc](googleapis/java-core@942e8cc)) ### Dependencies * Update google-cloud-shared-config to v1.5.3 ([#882](googleapis/java-core#882)) ([5997769](googleapis/java-core@5997769)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* chore: fix license header in build.bat * chore: add disctribution field for setup-java action Source-Link: googleapis/synthtool@4fea5f4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:df8d7b2cc0dbc65871e7edd86601901a0612b272fa3f7f0eb590c5c53aa5f92e

…) (#882) * chore: Enable Size-Label bot in all googleapis Java repositories Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis Java repositories * Remove product Remove product since it is by default true * add license header Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com> Source-Link: googleapis/synthtool@54b2c6a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:fc52b202aa298a50a12c64efd04fea3884d867947effe2fa85382a246c09e813 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [1.114.7](https://www.github.com/googleapis/java-pubsub/compare/v1.114.6...v1.114.7) (2021-10-19) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.1.8 ([#877](https://www.github.com/googleapis/java-pubsub/issues/877)) ([c76329b](https://www.github.com/googleapis/java-pubsub/commit/c76329b06f2f620662f4fe4ffefa897daea8703b)) * update dependency com.google.cloud:google-cloud-core to v2.2.0 ([#881](https://www.github.com/googleapis/java-pubsub/issues/881)) ([1eb4a1f](https://www.github.com/googleapis/java-pubsub/commit/1eb4a1f0a7d318b88cd04f4aefd3191f289e8a0f)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.4.0 ([#882](https://www.github.com/googleapis/java-pubsub/issues/882)) ([2c367bb](https://www.github.com/googleapis/java-pubsub/commit/2c367bb22860cbbfa57fca70a436919ac6aa8084)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [1.114.7](https://www.github.com/googleapis/java-pubsub/compare/v1.114.6...v1.114.7) (2021-10-19) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.1.8 ([#877](https://www.github.com/googleapis/java-pubsub/issues/877)) ([3b58523](https://www.github.com/googleapis/java-pubsub/commit/3b5852361ed62f443b73ffd7a5fc30982f762c03)) * update dependency com.google.cloud:google-cloud-core to v2.2.0 ([#881](https://www.github.com/googleapis/java-pubsub/issues/881)) ([cd9695c](https://www.github.com/googleapis/java-pubsub/commit/cd9695c41c6d353cbec72df40c9140d596af60c7)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.4.0 ([#882](https://www.github.com/googleapis/java-pubsub/issues/882)) ([ed9c163](https://www.github.com/googleapis/java-pubsub/commit/ed9c163dba0b161267224ef10ff21be54bea09ee)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 8, 2016

mderka added the api: dns Issues related to the Cloud DNS API. label Apr 8, 2016

mderka reviewed Apr 8, 2016
View reviewed changes

Comment thread gcloud-java-dns/src/test/java/com/google/gcloud/dns/DnsImplTest.java Outdated

import org.junit.Before;

import org.junit.Test;

import java.net.SocketTimeoutException;

This comment was marked as spam.

Sign in to view

mderka force-pushed the retryhelper branch from d976ed4 to 0bdf0ed Compare April 8, 2016 21:27

RetryHelper can be configured to not retry on socket timeouts.

03e1eaf

This fixes googleapis#816 and googleapis#808.

mderka force-pushed the retryhelper branch from 0bdf0ed to 03e1eaf Compare April 8, 2016 21:50

mderka added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 8, 2016

aozarov closed this Apr 9, 2016

suztomo pushed a commit that referenced this pull request Feb 1, 2023

deps: Update google-cloud-shared-config to v1.5.3 (#882)

5997769

chingor13 pushed a commit that referenced this pull request Jan 6, 2026

deps: update dependency org.easymock:easymock to v5 (#882)

70e889f

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

RetryHelper can be configured to not retry on socket timeouts.#882

RetryHelper can be configured to not retry on socket timeouts.#882
mderka wants to merge 1 commit into
googleapis:masterfrom
mderka:retryhelper

mderka commented Apr 8, 2016

Uh oh!

coveralls commented Apr 8, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

mderka commented Apr 8, 2016

Uh oh!

coveralls commented Apr 8, 2016

Uh oh!

coveralls commented Apr 8, 2016

Uh oh!

mderka commented Apr 8, 2016

Uh oh!

aozarov commented Apr 9, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

mderka commented Apr 8, 2016

Uh oh!

coveralls commented Apr 8, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

mderka commented Apr 8, 2016

Uh oh!

coveralls commented Apr 8, 2016

Uh oh!

coveralls commented Apr 8, 2016

Uh oh!

mderka commented Apr 8, 2016

Uh oh!

aozarov commented Apr 9, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants