Refresh VPCSC tests for monitoring V3 by steinwaywhw · Pull Request #6472 · googleapis/google-cloud-java · GitHub
Skip to content

Refresh VPCSC tests for monitoring V3#6472

Merged
chingor13 merged 2 commits into
googleapis:masterfrom
steinwaywhw:patch-1
Oct 9, 2019
Merged

Refresh VPCSC tests for monitoring V3#6472
chingor13 merged 2 commits into
googleapis:masterfrom
steinwaywhw:patch-1

Conversation

@steinwaywhw

Copy link
Copy Markdown
Contributor

The codegen was updated recently, as well as the protos. This is to refresh the auto-generated tests for VPCSC for the monitoring v3 clients.

The codegen was updated recently, as well as the protos. This is to refresh the auto-generated tests for VPCSC for the monitoring v3 clients.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 9, 2019

@chingor13 chingor13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to a git mv to preserve any history (and to help with the diff)?

Also, do we need the "V3" in the class name (v3 is already in the java package)?

@codecov

codecov Bot commented Oct 9, 2019

Copy link
Copy Markdown

@steinwaywhw

Copy link
Copy Markdown
Contributor Author

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2019
@chingor13 chingor13 merged commit 9476314 into googleapis:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants