{{ message }}
[Bigtable] Updated javaDoc for callable being wrapper around read & write#6431
Merged
Conversation
googlebot
added
the
cla: yes
igorbernstein2
requested changes
Oct 3, 2019
igorbernstein2
left a comment
igorbernstein2
left a comment
Contributor
There was a problem hiding this comment.
I think this needs to be worked in to the existing doc better.
Contributor
There was a problem hiding this comment.
Please provide an example
Contributor
There was a problem hiding this comment.
Actually looking at the docs, it seems like the callables info is already there:
* <li>A "callable" method, like `readRowsCallable()`. This type of method takes no parameters and
* returns an immutable API callable object, which can be used to initiate calls to the * returns an immutable API callable object, which can be used to initiate calls to the
* service. * service.
I think all this needs is just an example:
Taking ReadRows as an example:
// These two invocation are equivalent
ServerStream<Row> stream1 = client.readRows(query);
ServerStream<Row> stream2 = client.readRowsCallable().call(query);
// These two invocation are also equivalent
client.readRowsAsync(query, observer);
client.readRowsCallable().call(query, observer); 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4054
Updated JavaDoc for callable being wrapper around read & write Operation.