fix: bump grpc-google-iam to 0.13.0 to introduce GetPolicyOptions by jkwlui · Pull Request #6379 · googleapis/google-cloud-java · GitHub
Skip to content

fix: bump grpc-google-iam to 0.13.0 to introduce GetPolicyOptions#6379

Merged
frankyn merged 1 commit into
googleapis:masterfrom
jkwlui:bump-iam
Oct 1, 2019
Merged

fix: bump grpc-google-iam to 0.13.0 to introduce GetPolicyOptions#6379
frankyn merged 1 commit into
googleapis:masterfrom
jkwlui:bump-iam

Conversation

@jkwlui

@jkwlui jkwlui commented Sep 30, 2019

Copy link
Copy Markdown

This is blocking new regeneration of libraries with updated IAM methods.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2019

@vam-google vam-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please clarify (in PR description and commit message) what exactly this fix "fixes" (it only bumps the dependency version, but it seems like old one worked just fine for google-cloud-java).

@jkwlui jkwlui changed the title fix: bump grpc-google-iam to 0.13.0 fix: bump grpc-google-iam to 0.13.0 to introduce GetPolicyOptions Sep 30, 2019
@codecov

codecov Bot commented Sep 30, 2019

Copy link
Copy Markdown

@elharo

elharo commented Oct 1, 2019

Copy link
Copy Markdown
Contributor

@frankyn frankyn merged commit 96e692d into googleapis:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants