Updated JavaDoc to mention connection pooling over ManagedChannel by rahulKQL · Pull Request #6328 · googleapis/google-cloud-java · GitHub
Skip to content

Updated JavaDoc to mention connection pooling over ManagedChannel#6328

Merged
igorbernstein2 merged 3 commits into
googleapis:masterfrom
rahulKQL:issue_5190
Oct 8, 2019
Merged

Updated JavaDoc to mention connection pooling over ManagedChannel#6328
igorbernstein2 merged 3 commits into
googleapis:masterfrom
rahulKQL:issue_5190

Conversation

@rahulKQL

Copy link
Copy Markdown
Contributor

Fixes #5190

Updated JavaDoc at EnhancedBigtableStubSetting#defaultTransportChannelProvider to mention about connection pooling over ManagedChannel.

@rahulKQL rahulKQL added the api: bigtable Issues related to the Bigtable API. label Sep 24, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2019

@igorbernstein2 igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stub settings aren’t really visible to the user. I think this needs to be bubbled up to BigtableDataSettings’ class description

@codecov

codecov Bot commented Sep 24, 2019

Copy link
Copy Markdown

@rahulKQL

Copy link
Copy Markdown
Contributor Author

@igorbernstein2 igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorbernstein2 igorbernstein2 merged commit 8e747b2 into googleapis:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bigtable: Update docs to make it obvious that a connection pool is being used

4 participants