{{ message }}
Bigtable: update pom.xml to fail loudly when an invalid profile id is passed#6141
Merged
chingor13 merged 1 commit intoAug 26, 2019
Merged
Conversation
… passed Bigtable uses maven profiles for running integration tests. If the user mistypes the profile id, the test profile isn't activated and the build succeeds, giving a false positive result. This PR will just fail the build
googlebot
added
the
cla: yes
igorbernstein2
added
api: bigtable
googlebot
added
the
cla: yes
chingor13
approved these changes
Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bigtable uses maven profiles for running integration tests. If the user mistypes the profile id, the test profile isn't activated and the build succeeds, giving a false positive result. This PR will just fail the build
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)