{{ message }}
storage: add benchwrapper#6062
Merged
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
Codecov Report
@@ Coverage Diff @@
## master #6062 +/- ##
============================================
- Coverage 47.38% 47.02% -0.37%
+ Complexity 27182 25717 -1465
============================================
Files 2523 2523
Lines 274600 269325 -5275
Branches 31383 31190 -193
============================================
- Hits 130124 126647 -3477
+ Misses 134863 134000 -863
+ Partials 9613 8678 -935
Continue to review full report at Codecov.
|
Author
Done
What are the commands that need to be run to do that? |
kolea2
reviewed
Aug 19, 2019
chingor13
requested changes
Aug 19, 2019
chingor13
reviewed
Aug 19, 2019
Author
|
Thanks for the second review. All comments addressed. |
kolea2
previously requested changes
Aug 20, 2019
Author
|
Thanks for the third review. All comments addressed. |
elharo
reviewed
Aug 20, 2019
Author
|
Thanks for the fourth review. All comments addressed. |
elharo
reviewed
Aug 20, 2019
elharo
reviewed
Aug 20, 2019
Author
|
Thanks for the fifth review. All comments addressed. |
elharo
reviewed
Aug 21, 2019
This adds a small gRPC server around the google-cloud-storage client library, which allows g3 benchmarking code to prod at the library and record measurements without needing to be written in Java / be in the same repository. Since g3 requires TLS on all connections, the server is TLS-ed with a dummy cert. These certs aren't intended to be private: the kokoro environment is the only place this gets run. (never in prod, etc)
Author
chingor13
approved these changes
Sep 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a small gRPC server around the google-cloud-storage client library,
which allows g3 benchmarking code to prod at the library and record
measurements without needing to be written in Java / be in the same repository.
Since g3 requires TLS on all connections, the server is TLS-ed with a dummy
cert. These certs aren't intended to be private: the kokoro environment
is the only place this gets run. (never in prod, etc)
ps: I'm not sure what the right place to put this code is. Minimally it requires the local version of google-cloud-storage, so I stuck it alongside it. Perhaps there's a better place, with a way to access google-cloud-storage without going to maven though.