{{ message }}
Storage: Fix locationType field is added in bucket#5725
Merged
JesseLovelace merged 5 commits intoJul 17, 2019
Conversation
googlebot
added
the
cla: yes
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
chingor13
changed the title
frankyn
suggested changes
Jul 11, 2019
| } | ||
|
|
||
| @Override | ||
| public Builder setLocationType(String locationType) { |
Contributor
There was a problem hiding this comment.
I think this should be a private setLocationType due to read-only.
| } | ||
|
|
||
| @Override | ||
| public Builder setLocationType(String locationType) { |
JesseLovelace
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
frankyn
approved these changes
Jul 16, 2019
Contributor
JesseLovelace
approved these changes
Jul 17, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5442
Due to
LocationTypeis a read-only field, So Have not added test case specific fordual-regionorregionlocationType.