Add Tasks smoke test by chingor13 · Pull Request #5628 · googleapis/google-cloud-java · GitHub
Skip to content

Add Tasks smoke test#5628

Merged
chingor13 merged 7 commits into
googleapis:masterfrom
chingor13:tasks-smoke-test
Jul 3, 2019
Merged

Add Tasks smoke test#5628
chingor13 merged 7 commits into
googleapis:masterfrom
chingor13:tasks-smoke-test

Conversation

@chingor13

Copy link
Copy Markdown
Contributor

This test is adapted from java-docs-samples.

@chingor13 chingor13 requested a review from a team July 1, 2019 20:10
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2019
@codecov-io

codecov-io commented Jul 1, 2019

Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor - want to inline this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the existing format for the generated SmokeTests (example)

@chingor13 chingor13 merged commit 13928f8 into googleapis:master Jul 3, 2019
@chingor13 chingor13 deleted the tasks-smoke-test branch July 3, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants